Credential Manager: Switch 'request()' to GetAutofillableLogins().

components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc

Index: components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc
diff --git a/components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc b/components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc
index 1800c322175987280c8c8a3f17fb13af1349ac29..7f9482e9cf3dd9816e6bdb1438a313cd26ca3144 100644
--- a/components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc
+++ b/components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc
@@ -138,6 +138,13 @@ class ContentCredentialManagerDispatcherTest
     form_.signon_realm = form_.origin.spec();
     form_.scheme = autofill::PasswordForm::SCHEME_HTML;
 
+    cross_origin_form_.username_value = base::ASCIIToUTF16("Username");
+    cross_origin_form_.display_name = base::ASCIIToUTF16("Display Name");
+    cross_origin_form_.password_value = base::ASCIIToUTF16("Password");
+    cross_origin_form_.origin = GURL("https://example.net/");
+    cross_origin_form_.signon_realm = cross_origin_form_.origin.spec();
+    cross_origin_form_.scheme = autofill::PasswordForm::SCHEME_HTML;
+
     store_->Clear();
     EXPECT_TRUE(store_->IsEmpty());
   }
@@ -151,6 +158,7 @@ class ContentCredentialManagerDispatcherTest
 
  protected:
   autofill::PasswordForm form_;
+  autofill::PasswordForm cross_origin_form_;
   scoped_refptr<TestPasswordStore> store_;
   scoped_ptr<ContentCredentialManagerDispatcher> dispatcher_;
   scoped_ptr<TestPasswordManagerClient> client_;
@@ -230,6 +238,7 @@ TEST_F(ContentCredentialManagerDispatcherTest,
 TEST_F(ContentCredentialManagerDispatcherTest,
        CredentialManagerOnRequestCredentialWithFullPasswordStore) {
   store_->AddLogin(form_);
+  store_->AddLogin(cross_origin_form_);

[vabr (Chromium), 2014/12/15 10:47:22]

I'm not sure what are you testing here. That the SendCredential message is sent
even though the store also contains credentials for other sites?

[Mike West, 2014/12/15 12:59:24]

We're now requesting all the data, not just all the data for a specific origin.
I want to ensure that extra data in the DB doesn't confuse things.

Splitting this out into a separate test for clarity.

[vabr (Chromium), 2014/12/15 13:27:25]

Acknowledged, the new test makes good sense to me.

 
   std::vector<GURL> federations;
   dispatcher()->OnRequestCredential(kRequestId, false, federations);