Credential Manager: Switch 'request()' to GetAutofillableLogins().

components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/password_manager/content/browser/content_credential_manager_dispatcher.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/run_loop.h"
 #include "base/strings/string16.h"
@@ skipping 120 matching lines @@
 
     NavigateAndCommit(GURL("https://example.com/test.html"));
 
     form_.username_value = base::ASCIIToUTF16("Username");
     form_.display_name = base::ASCIIToUTF16("Display Name");
     form_.password_value = base::ASCIIToUTF16("Password");
     form_.origin = web_contents()->GetLastCommittedURL().GetOrigin();
     form_.signon_realm = form_.origin.spec();
     form_.scheme = autofill::PasswordForm::SCHEME_HTML;
 
+    cross_origin_form_.username_value = base::ASCIIToUTF16("Username");
+    cross_origin_form_.display_name = base::ASCIIToUTF16("Display Name");
+    cross_origin_form_.password_value = base::ASCIIToUTF16("Password");
+    cross_origin_form_.origin = GURL("https://example.net/");
+    cross_origin_form_.signon_realm = cross_origin_form_.origin.spec();
+    cross_origin_form_.scheme = autofill::PasswordForm::SCHEME_HTML;
+
     store_->Clear();
     EXPECT_TRUE(store_->IsEmpty());
   }
 
   void TearDown() override {
     store_->Shutdown();
     content::RenderViewHostTestHarness::TearDown();
   }
 
   ContentCredentialManagerDispatcher* dispatcher() { return dispatcher_.get(); }
 
  protected:
   autofill::PasswordForm form_;
+  autofill::PasswordForm cross_origin_form_;
   scoped_refptr<TestPasswordStore> store_;
   scoped_ptr<ContentCredentialManagerDispatcher> dispatcher_;
   scoped_ptr<TestPasswordManagerClient> client_;
   StubPasswordManagerDriver stub_driver_;
 };
 
 TEST_F(ContentCredentialManagerDispatcherTest,
        CredentialManagerOnNotifyFailedSignIn) {
   CredentialInfo info;
   info.type = CREDENTIAL_TYPE_LOCAL;
@@ skipping 59 matching lines @@
   CredentialManagerMsg_SendCredential::Param param;
   CredentialManagerMsg_SendCredential::Read(message, &param);
   EXPECT_EQ(CREDENTIAL_TYPE_EMPTY, param.b.type);
   process()->sink().ClearMessages();
   EXPECT_FALSE(client_->did_prompt_user_to_choose());
 }
 
 TEST_F(ContentCredentialManagerDispatcherTest,
        CredentialManagerOnRequestCredentialWithFullPasswordStore) {
   store_->AddLogin(form_);
+  store_->AddLogin(cross_origin_form_);

[vabr (Chromium), 2014/12/15 10:47:22]

I'm not sure what are you testing here. That the SendCredential message is sent
even though the store also contains credentials for other sites?

[Mike West, 2014/12/15 12:59:24]

We're now requesting all the data, not just all the data for a specific origin.
I want to ensure that extra data in the DB doesn't confuse things.

Splitting this out into a separate test for clarity.

[vabr (Chromium), 2014/12/15 13:27:25]

Acknowledged, the new test makes good sense to me.

 
   std::vector<GURL> federations;
   dispatcher()->OnRequestCredential(kRequestId, false, federations);
 
   RunAllPendingTasks();
 
   const uint32 kMsgID = CredentialManagerMsg_SendCredential::ID;
   const IPC::Message* message =
       process()->sink().GetFirstMessageMatching(kMsgID);
   EXPECT_TRUE(message);
@@ skipping 30 matching lines @@
   EXPECT_TRUE(message);
   CredentialManagerMsg_SendCredential::Param send_param;
   CredentialManagerMsg_SendCredential::Read(message, &send_param);
   CredentialManagerMsg_SendCredential::Read(message, &send_param);
   EXPECT_NE(CREDENTIAL_TYPE_EMPTY, send_param.b.type);
   process()->sink().ClearMessages();
   EXPECT_TRUE(client_->did_prompt_user_to_choose());
 }
 
 }  // namespace password_manager