Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: LayoutTests/fast/css-grid-layout/grid-content-sized-columns-resolution-expected.txt

Issue 802243003: [CSS Grid Layout] Incorrect sizing of tracks with non-spanning items (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebased + Test fixes Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/css-grid-layout/grid-content-sized-columns-resolution-expected.txt
diff --git a/LayoutTests/fast/css-grid-layout/grid-content-sized-columns-resolution-expected.txt b/LayoutTests/fast/css-grid-layout/grid-content-sized-columns-resolution-expected.txt
index 9304929209382de3e1daf9fe22a368f714d04155..8b8da0ce195d4ba03482fba365432008a8e3d5e3 100644
--- a/LayoutTests/fast/css-grid-layout/grid-content-sized-columns-resolution-expected.txt
+++ b/LayoutTests/fast/css-grid-layout/grid-content-sized-columns-resolution-expected.txt
@@ -13,7 +13,7 @@ PASS window.getComputedStyle(gridMaxContentAndMaxContentFixed, '').getPropertyVa
Check that items are processed by ascending span to compute track breadths forbidding extra space distribution.
PASS window.getComputedStyle(gridMinContentFixedAndAutoUnsortedConstrained, '').getPropertyValue('grid-template-columns') is "0px 40px"
-PASS window.getComputedStyle(gridAutoAndAutoUnsortedConstrained, '').getPropertyValue('grid-template-columns') is "5px 35px"
+PASS window.getComputedStyle(gridAutoAndAutoUnsortedConstrained, '').getPropertyValue('grid-template-columns') is "10px 30px"
Julien - ping for review 2015/01/14 09:59:27 Interesting, the algorithm forces the second colum
svillar 2015/01/14 10:11:56 Yeah, with just one spanning grid item and "auto a
PASS window.getComputedStyle(gridMinContentAndMinContentFixedUnsortedConstrained, '').getPropertyValue('grid-template-columns') is "0px 40px"
PASS window.getComputedStyle(gridMaxContentAndMinContentUnsortedConstrained, '').getPropertyValue('grid-template-columns') is "0px 70px"
PASS window.getComputedStyle(gridFixedMinContentAndMaxContentUnsortedConstrained, '').getPropertyValue('grid-template-columns') is "10px 70px"
@@ -27,7 +27,7 @@ PASS window.getComputedStyle(gridMaxContentAndMaxContentFixedUnsortedConstrained
Check that items are processed by ascending span to compute track breadths allowing extra space distribution.
PASS window.getComputedStyle(gridMinContentFixedAndAutoUnsorted, '').getPropertyValue('grid-template-columns') is "15px 90px"
-PASS window.getComputedStyle(gridAutoAndAutoUnsorted, '').getPropertyValue('grid-template-columns') is "30px 60px"
+PASS window.getComputedStyle(gridAutoAndAutoUnsorted, '').getPropertyValue('grid-template-columns') is "60px 30px"
PASS window.getComputedStyle(gridMinContentAndMinContentFixedUnsorted, '').getPropertyValue('grid-template-columns') is "0px 40px"
PASS window.getComputedStyle(gridMaxContentAndMinContentUnsorted, '').getPropertyValue('grid-template-columns') is "0px 70px"
PASS window.getComputedStyle(gridFixedMinContentAndMaxContentUnsorted, '').getPropertyValue('grid-template-columns') is "10px 70px"

Powered by Google App Engine
This is Rietveld 408576698