LayoutTests/fast/css-grid-layout/grid-content-sized-columns-resolution-expected.txt - Issue 802243003: [CSS Grid Layout] Incorrect sizing of tracks with non-spanning items

Side by Side Diff: LayoutTests/fast/css-grid-layout/grid-content-sized-columns-resolution-expected.txt

Issue 802243003: [CSS Grid Layout] Incorrect sizing of tracks with non-spanning items (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebased + Test fixes Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/css-grid-layout/grid-content-sized-columns-resolution.html ('k') | LayoutTests/fast/css-grid-layout/grid-initialize-span-one-items.html » ('j') | Source/core/rendering/RenderGrid.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 PASS window.getComputedStyle(gridMinContentFixedAndAuto, '').getPropertyValue('g rid-template-columns') is "15px 75px"	1 PASS window.getComputedStyle(gridMinContentFixedAndAuto, '').getPropertyValue('g rid-template-columns') is "15px 75px"

2 PASS window.getComputedStyle(gridAutoAndAuto, '').getPropertyValue('grid-templat e-columns') is "45px 45px"	2 PASS window.getComputedStyle(gridAutoAndAuto, '').getPropertyValue('grid-templat e-columns') is "45px 45px"

3 PASS window.getComputedStyle(gridMinContentAndMinContentFixed, '').getPropertyVa lue('grid-template-columns') is "20px 30px"	3 PASS window.getComputedStyle(gridMinContentAndMinContentFixed, '').getPropertyVa lue('grid-template-columns') is "20px 30px"

4 PASS window.getComputedStyle(gridMaxContentAndMinContent, '').getPropertyValue(' grid-template-columns') is "70px 20px"	4 PASS window.getComputedStyle(gridMaxContentAndMinContent, '').getPropertyValue(' grid-template-columns') is "70px 20px"

5 PASS window.getComputedStyle(gridFixedMinContentAndMaxContent, '').getPropertyVa lue('grid-template-columns') is "10px 80px"	5 PASS window.getComputedStyle(gridFixedMinContentAndMaxContent, '').getPropertyVa lue('grid-template-columns') is "10px 80px"

6 PASS window.getComputedStyle(gridFixedMaxContentAndMinContent, '').getPropertyVa lue('grid-template-columns') is "60px 30px"	6 PASS window.getComputedStyle(gridFixedMaxContentAndMinContent, '').getPropertyVa lue('grid-template-columns') is "60px 30px"

7 PASS window.getComputedStyle(gridMinContentAndMaxContentFixed, '').getPropertyVa lue('grid-template-columns') is "20px 70px"	7 PASS window.getComputedStyle(gridMinContentAndMaxContentFixed, '').getPropertyVa lue('grid-template-columns') is "20px 70px"

8 PASS window.getComputedStyle(gridMaxContentFixedAndAuto, '').getPropertyValue('g rid-template-columns') is "65px 25px"	8 PASS window.getComputedStyle(gridMaxContentFixedAndAuto, '').getPropertyValue('g rid-template-columns') is "65px 25px"

9 PASS window.getComputedStyle(gridAutoMinContent, '').getPropertyValue('grid-temp late-columns') is "70px 20px"	9 PASS window.getComputedStyle(gridAutoMinContent, '').getPropertyValue('grid-temp late-columns') is "70px 20px"

10 PASS window.getComputedStyle(gridAutoMaxContent, '').getPropertyValue('grid-temp late-columns') is "20px 70px"	10 PASS window.getComputedStyle(gridAutoMaxContent, '').getPropertyValue('grid-temp late-columns') is "20px 70px"

11 PASS window.getComputedStyle(gridMaxContentAndMinContentFixed, '').getPropertyVa lue('grid-template-columns') is "70px 20px"	11 PASS window.getComputedStyle(gridMaxContentAndMinContentFixed, '').getPropertyVa lue('grid-template-columns') is "70px 20px"

12 PASS window.getComputedStyle(gridMaxContentAndMaxContentFixed, '').getPropertyVa lue('grid-template-columns') is "55px 35px"	12 PASS window.getComputedStyle(gridMaxContentAndMaxContentFixed, '').getPropertyVa lue('grid-template-columns') is "55px 35px"

13	13

14 Check that items are processed by ascending span to compute track breadths forbi dding extra space distribution.	14 Check that items are processed by ascending span to compute track breadths forbi dding extra space distribution.

15 PASS window.getComputedStyle(gridMinContentFixedAndAutoUnsortedConstrained, ''). getPropertyValue('grid-template-columns') is "0px 40px"	15 PASS window.getComputedStyle(gridMinContentFixedAndAutoUnsortedConstrained, ''). getPropertyValue('grid-template-columns') is "0px 40px"

16 PASS window.getComputedStyle(gridAutoAndAutoUnsortedConstrained, '').getProperty Value('grid-template-columns') is "5px 35px"	16 PASS window.getComputedStyle(gridAutoAndAutoUnsortedConstrained, '').getProperty Value('grid-template-columns') is "10px 30px"
	Julien - ping for review 2015/01/14 09:59:27 Interesting, the algorithm forces the second colum Interesting, the algorithm forces the second column to be sized by the non-spanning grid items (whose min-content and max-content size are 30px). svillar 2015/01/14 10:11:56 Yeah, with just one spanning grid item and "auto a Show quoted text On 2015/01/14 09:59:27, Julien Chaffraix - CET wrote: > Interesting, the algorithm forces the second column to be sized by the > non-spanning grid items (whose min-content and max-content size are 30px). Yeah, with just one spanning grid item and "auto auto" both columns would get the same size, but non-spanning grid items kind of have a greater influence on the sizes of tracks, I guess it's because they won't be revisited after that initialization.
17 PASS window.getComputedStyle(gridMinContentAndMinContentFixedUnsortedConstrained , '').getPropertyValue('grid-template-columns') is "0px 40px"	17 PASS window.getComputedStyle(gridMinContentAndMinContentFixedUnsortedConstrained , '').getPropertyValue('grid-template-columns') is "0px 40px"

18 PASS window.getComputedStyle(gridMaxContentAndMinContentUnsortedConstrained, '') .getPropertyValue('grid-template-columns') is "0px 70px"	18 PASS window.getComputedStyle(gridMaxContentAndMinContentUnsortedConstrained, '') .getPropertyValue('grid-template-columns') is "0px 70px"

19 PASS window.getComputedStyle(gridFixedMinContentAndMaxContentUnsortedConstrained , '').getPropertyValue('grid-template-columns') is "10px 70px"	19 PASS window.getComputedStyle(gridFixedMinContentAndMaxContentUnsortedConstrained , '').getPropertyValue('grid-template-columns') is "10px 70px"

20 PASS window.getComputedStyle(gridFixedMaxContentAndMinContentUnsortedConstrained , '').getPropertyValue('grid-template-columns') is "10px 40px"	20 PASS window.getComputedStyle(gridFixedMaxContentAndMinContentUnsortedConstrained , '').getPropertyValue('grid-template-columns') is "10px 40px"

21 PASS window.getComputedStyle(gridMinContentAndMaxContentFixedUnsortedConstrained , '').getPropertyValue('grid-template-columns') is "0px 90px"	21 PASS window.getComputedStyle(gridMinContentAndMaxContentFixedUnsortedConstrained , '').getPropertyValue('grid-template-columns') is "0px 90px"

22 PASS window.getComputedStyle(gridMaxContentFixedAndAutoUnsortedConstrained, ''). getPropertyValue('grid-template-columns') is "10px 40px"	22 PASS window.getComputedStyle(gridMaxContentFixedAndAutoUnsortedConstrained, ''). getPropertyValue('grid-template-columns') is "10px 40px"

23 PASS window.getComputedStyle(gridAutoMinContentUnsortedConstrained, '').getPrope rtyValue('grid-template-columns') is "0px 60px"	23 PASS window.getComputedStyle(gridAutoMinContentUnsortedConstrained, '').getPrope rtyValue('grid-template-columns') is "0px 60px"

24 PASS window.getComputedStyle(gridAutoMaxContentUnsortedConstrained, '').getPrope rtyValue('grid-template-columns') is "0px 90px"	24 PASS window.getComputedStyle(gridAutoMaxContentUnsortedConstrained, '').getPrope rtyValue('grid-template-columns') is "0px 90px"

25 PASS window.getComputedStyle(gridMaxContentAndMinContentFixedUnsortedConstrained , '').getPropertyValue('grid-template-columns') is "50px 40px"	25 PASS window.getComputedStyle(gridMaxContentAndMinContentFixedUnsortedConstrained , '').getPropertyValue('grid-template-columns') is "50px 40px"

26 PASS window.getComputedStyle(gridMaxContentAndMaxContentFixedUnsortedConstrained , '').getPropertyValue('grid-template-columns') is "40px 70px"	26 PASS window.getComputedStyle(gridMaxContentAndMaxContentFixedUnsortedConstrained , '').getPropertyValue('grid-template-columns') is "40px 70px"

27	27

28 Check that items are processed by ascending span to compute track breadths allow ing extra space distribution.	28 Check that items are processed by ascending span to compute track breadths allow ing extra space distribution.

29 PASS window.getComputedStyle(gridMinContentFixedAndAutoUnsorted, '').getProperty Value('grid-template-columns') is "15px 90px"	29 PASS window.getComputedStyle(gridMinContentFixedAndAutoUnsorted, '').getProperty Value('grid-template-columns') is "15px 90px"

30 PASS window.getComputedStyle(gridAutoAndAutoUnsorted, '').getPropertyValue('grid -template-columns') is "30px 60px"	30 PASS window.getComputedStyle(gridAutoAndAutoUnsorted, '').getPropertyValue('grid -template-columns') is "60px 30px"

31 PASS window.getComputedStyle(gridMinContentAndMinContentFixedUnsorted, '').getPr opertyValue('grid-template-columns') is "0px 40px"	31 PASS window.getComputedStyle(gridMinContentAndMinContentFixedUnsorted, '').getPr opertyValue('grid-template-columns') is "0px 40px"

32 PASS window.getComputedStyle(gridMaxContentAndMinContentUnsorted, '').getPropert yValue('grid-template-columns') is "0px 70px"	32 PASS window.getComputedStyle(gridMaxContentAndMinContentUnsorted, '').getPropert yValue('grid-template-columns') is "0px 70px"

33 PASS window.getComputedStyle(gridFixedMinContentAndMaxContentUnsorted, '').getPr opertyValue('grid-template-columns') is "10px 70px"	33 PASS window.getComputedStyle(gridFixedMinContentAndMaxContentUnsorted, '').getPr opertyValue('grid-template-columns') is "10px 70px"

34 PASS window.getComputedStyle(gridFixedMaxContentAndMinContentUnsorted, '').getPr opertyValue('grid-template-columns') is "50px 40px"	34 PASS window.getComputedStyle(gridFixedMaxContentAndMinContentUnsorted, '').getPr opertyValue('grid-template-columns') is "50px 40px"

35 PASS window.getComputedStyle(gridMinContentAndMaxContentFixedUnsorted, '').getPr opertyValue('grid-template-columns') is "0px 90px"	35 PASS window.getComputedStyle(gridMinContentAndMaxContentFixedUnsorted, '').getPr opertyValue('grid-template-columns') is "0px 90px"

36 PASS window.getComputedStyle(gridMaxContentFixedAndAutoUnsorted, '').getProperty Value('grid-template-columns') is "15px 70px"	36 PASS window.getComputedStyle(gridMaxContentFixedAndAutoUnsorted, '').getProperty Value('grid-template-columns') is "15px 70px"

37 PASS window.getComputedStyle(gridAutoMinContentUnsorted, '').getPropertyValue('g rid-template-columns') is "50px 60px"	37 PASS window.getComputedStyle(gridAutoMinContentUnsorted, '').getPropertyValue('g rid-template-columns') is "50px 60px"

38 PASS window.getComputedStyle(gridAutoMaxContentUnsorted, '').getPropertyValue('g rid-template-columns') is "0px 90px"	38 PASS window.getComputedStyle(gridAutoMaxContentUnsorted, '').getPropertyValue('g rid-template-columns') is "0px 90px"

39 PASS window.getComputedStyle(gridMaxContentAndMinContentFixedUnsorted, '').getPr opertyValue('grid-template-columns') is "50px 40px"	39 PASS window.getComputedStyle(gridMaxContentAndMinContentFixedUnsorted, '').getPr opertyValue('grid-template-columns') is "50px 40px"

40 PASS window.getComputedStyle(gridMaxContentAndMaxContentFixedUnsorted, '').getPr opertyValue('grid-template-columns') is "40px 70px"	40 PASS window.getComputedStyle(gridMaxContentAndMaxContentFixedUnsorted, '').getPr opertyValue('grid-template-columns') is "40px 70px"

(...skipping 83 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
124 XX XX XX XX	124 XX XX XX XX

125 XXXXXXX	125 XXXXXXX

126 XXXX XXXX	126 XXXX XXXX

127 XXXXXXXXXXX	127 XXXXXXXXXXX

128 XXXX XXXX	128 XXXX XXXX

129 XXXXXXXXXXXXXXX	129 XXXXXXXXXXXXXXX

130 XXXX XXXX	130 XXXX XXXX

131 XXXXXXXXXX	131 XXXXXXXXXX

132 XXXX XXXX	132 XXXX XXXX

133 XXXXXXXXXXXXXXX	133 XXXXXXXXXXXXXXX

OLD	NEW