Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: LayoutTests/fast/css-grid-layout/minmax-spanning-resolution-columns.html

Issue 802243003: [CSS Grid Layout] Incorrect sizing of tracks with non-spanning items (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/css-grid-layout/minmax-spanning-resolution-columns.html
diff --git a/LayoutTests/fast/css-grid-layout/minmax-spanning-resolution-columns.html b/LayoutTests/fast/css-grid-layout/minmax-spanning-resolution-columns.html
index 7b06360e4ca609e460aa943c73d1c87dc6262685..74956783363c65f06c3c2ea88373bd5f7df3b9e3 100644
--- a/LayoutTests/fast/css-grid-layout/minmax-spanning-resolution-columns.html
+++ b/LayoutTests/fast/css-grid-layout/minmax-spanning-resolution-columns.html
@@ -192,9 +192,9 @@
<div class="unconstrainedContainer">
<div class="grid gridMinMaxMax">
- <div class="sizedToGridArea firstRowBothColumn" data-expected-width="110" data-expected-height="50">XXX XXX XXX</div>
+ <div class="sizedToGridArea firstRowBothColumn" data-expected-width="145" data-expected-height="50">XXX XXX XXX</div>
Julien - ping for review 2015/01/02 10:56:39 That looks like a regression to me: the spanning i
svillar 2015/01/02 11:36:54 The technical reason why it happens is because aft
<div class="sizedToGridArea firstRowFirstColumn" data-expected-width="50" data-expected-height="50"></div>
- <div class="sizedToGridArea firstRowSecondColumn" data-expected-width="60" data-expected-height="50"></div>
+ <div class="sizedToGridArea firstRowSecondColumn" data-expected-width="95" data-expected-height="50"></div>
</div>
</div>
@@ -230,36 +230,36 @@
<div style="width: 140px; height: 10px">
<div class="grid gridMinMaxMax">
<div class="sizedToGridArea firstRowBothColumn" data-expected-width="140" data-expected-height="50">XXXXXXXXXXXX XXXXXXXXXXXX</div>
- <div class="sizedToGridArea firstRowFirstColumn" data-expected-width="65" data-expected-height="50"></div>
- <div class="sizedToGridArea firstRowSecondColumn" data-expected-width="75" data-expected-height="50"></div>
+ <div class="sizedToGridArea firstRowFirstColumn" data-expected-width="60" data-expected-height="50"></div>
+ <div class="sizedToGridArea firstRowSecondColumn" data-expected-width="80" data-expected-height="50"></div>
</div>
</div>
<div style="width: 140px; height: 10px">
<div class="grid gridMinMaxMax">
<div class="sizedToGridArea bothRowBothColumn" data-expected-width="140" data-expected-height="150">XXXXXXXXXXXX XXXXXXXXXXXX</div>
- <div class="sizedToGridArea firstRowFirstColumn" data-expected-width="65" data-expected-height="50"></div>
- <div class="sizedToGridArea firstRowSecondColumn" data-expected-width="75" data-expected-height="50"></div>
- <div class="sizedToGridArea secondRowFirstColumn" data-expected-width="65" data-expected-height="100"></div>
- <div class="sizedToGridArea secondRowSecondColumn" data-expected-width="75" data-expected-height="100"></div>
+ <div class="sizedToGridArea firstRowFirstColumn" data-expected-width="60" data-expected-height="50"></div>
+ <div class="sizedToGridArea firstRowSecondColumn" data-expected-width="80" data-expected-height="50"></div>
+ <div class="sizedToGridArea secondRowFirstColumn" data-expected-width="60" data-expected-height="100"></div>
+ <div class="sizedToGridArea secondRowSecondColumn" data-expected-width="80" data-expected-height="100"></div>
</div>
</div>
<div class="unconstrainedContainer">
<div class="grid gridMinMaxMax">
<div class="sizedToGridArea firstRowBothColumn" data-expected-width="250" data-expected-height="50">XXXXXXXXXXXX XXXXXXXXXXXX</div>
- <div class="sizedToGridArea firstRowFirstColumn" data-expected-width="65" data-expected-height="50"></div>
- <div class="sizedToGridArea firstRowSecondColumn" data-expected-width="185" data-expected-height="50"></div>
+ <div class="sizedToGridArea firstRowFirstColumn" data-expected-width="60" data-expected-height="50"></div>
+ <div class="sizedToGridArea firstRowSecondColumn" data-expected-width="190" data-expected-height="50"></div>
</div>
</div>
<div class="unconstrainedContainer">
<div class="grid gridMinMaxMax">
<div class="sizedToGridArea bothRowBothColumn" data-expected-width="250" data-expected-height="150">XXXXXXXXXXXX XXXXXXXXXXXX</div>
- <div class="sizedToGridArea firstRowFirstColumn" data-expected-width="65" data-expected-height="50"></div>
- <div class="sizedToGridArea firstRowSecondColumn" data-expected-width="185" data-expected-height="50"></div>
- <div class="sizedToGridArea secondRowFirstColumn" data-expected-width="65" data-expected-height="100"></div>
- <div class="sizedToGridArea secondRowSecondColumn" data-expected-width="185" data-expected-height="100"></div>
+ <div class="sizedToGridArea firstRowFirstColumn" data-expected-width="60" data-expected-height="50"></div>
+ <div class="sizedToGridArea firstRowSecondColumn" data-expected-width="190" data-expected-height="50"></div>
+ <div class="sizedToGridArea secondRowFirstColumn" data-expected-width="60" data-expected-height="100"></div>
+ <div class="sizedToGridArea secondRowSecondColumn" data-expected-width="190" data-expected-height="100"></div>
</div>
</div>

Powered by Google App Engine
This is Rietveld 408576698