Chromium Code Reviews Chromium Code Reviews
Issue 802243003:
[CSS Grid Layout] Incorrect sizing of tracks with non-spanning items (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| Index: LayoutTests/fast/css-grid-layout/grid-initialize-span-one-items.html |
| diff --git a/LayoutTests/fast/css-grid-layout/grid-initialize-span-one-items.html b/LayoutTests/fast/css-grid-layout/grid-initialize-span-one-items.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..f507f50dae9c37b51784f15debc0f1ab8aa9cf98 |
| --- /dev/null |
| +++ b/LayoutTests/fast/css-grid-layout/grid-initialize-span-one-items.html |
| @@ -0,0 +1,87 @@ |
| +<html> |
|
Julien - ping for review
2015/01/02 10:56:39
You've forgotten the DOCTYPE :(
http://1funny.com
|
| +<head> |
| +<link href="resources/grid.css" rel="stylesheet"/> |
| +<style> |
| + .grid { |
| + font: 10px/1 Ahem; |
| + } |
| + .gridAutoAndAuto { |
| + grid-template-columns: auto auto; |
| + } |
| + .gridFixedMinContentFixedMaxContent { |
| + grid-template-columns: minmax(50px, min-content) minmax(40px, max-content); |
| + } |
| + .gridMaxContentAndAuto { |
| + grid-template-columns: max-content auto; |
| + } |
| + .gridMinContentAndAuto { |
| + grid-template-columns: min-content auto; |
| + } |
| +</style> |
| +<script src="../../resources/js-test.js"></script> |
| +</head> |
| +<body> |
|
Julien - ping for review
2015/01/02 10:56:39
Let's add a description of the test, por favor!
|
| +<div class="grid gridAutoAndAuto" id="gridAutoAndAuto"> |
| + <div class="firstRowFirstColumn">X</div> |
| + <div class="firstRowBothColumn">XXX XX XXX</div> |
| +</div> |
| + |
| +<div class="grid gridAutoAndAuto" id="gridAutoAndAutoReversed"> |
| + <div class="firstRowSecondColumn">X</div> |
| + <div class="firstRowBothColumn">XXX XX XXX</div> |
| +</div> |
| + |
| +<div class="grid gridFixedMinContentFixedMaxContent" id="gridFixedMinContentFixedMaxContent"> |
| + <div class="sizedToGridArea firstRowFirstColumn"></div> |
| + <div class="firstRowBothColumn">XXX XX XXX</div> |
| +</div> |
| + |
| +<div class="grid gridFixedMinContentFixedMaxContent" id="gridFixedMinContentFixedMaxContentTwoEmptyChildren"> |
| + <div class="sizedToGridArea firstRowFirstColumn"></div> |
| + <div class="sizedToGridArea firstRowSecondColumn"></div> |
| + <div class="firstRowBothColumn">XXX XX XXX</div> |
| +</div> |
| + |
| +<div class="grid gridFixedMinContentFixedMaxContent" id="gridFixedMinContentFixedMaxContentFixedSizeChild"> |
| + <div class="firstRowFirstColumn">XXXXXX</div> |
| + <div class="firstRowBothColumn">XXX XX XXX</div> |
| +</div> |
| + |
| +<div class="grid gridMaxContentAndAuto" id="gridMaxContentAndAuto"> |
| + <div class="firstRowFirstColumn">X</div> |
| + <div class="firstRowBothColumn">XXX XX XXX</div> |
| +</div> |
| + |
| +<div class="grid gridMaxContentAndAuto" id="gridMaxContentAndAutoReversed"> |
| + <div class="firstRowSecondColumn">X</div> |
| + <div class="firstRowBothColumn">XXX XX XXX</div> |
| +</div> |
| + |
| +<div class="grid gridMinContentAndAuto" id="gridMinContentAndAuto"> |
| + <div class="firstRowFirstColumn">X</div> |
| + <div class="firstRowBothColumn">XXX XX XXX</div> |
| +</div> |
| + |
| +<div class="grid gridMinContentAndAuto" id="gridMinContentAndAutoReversed"> |
| + <div class="firstRowSecondColumn">X</div> |
| + <div class="firstRowBothColumn">XXX XX XXX</div> |
| +</div> |
| + |
| +<script> |
| +function testGridColumnsValues(id, computedColumnValue) |
| +{ |
| + shouldBeEqualToString("window.getComputedStyle(" + id + ", '').getPropertyValue('grid-template-columns')", computedColumnValue); |
| +} |
| + |
| +testGridColumnsValues("gridAutoAndAuto", "10px 90px"); |
| +testGridColumnsValues("gridAutoAndAutoReversed", "90px 10px"); |
| +testGridColumnsValues("gridFixedMinContentFixedMaxContent", "50px 100px"); |
| +testGridColumnsValues("gridFixedMinContentFixedMaxContentTwoEmptyChildren", "50px 85px"); |
| +testGridColumnsValues("gridFixedMinContentFixedMaxContentFixedSizeChild", "60px 40px"); |
| +testGridColumnsValues("gridMaxContentAndAuto", "80px 90px"); |
| +testGridColumnsValues("gridMaxContentAndAutoReversed", "90px 10px"); |
| +testGridColumnsValues("gridMinContentAndAuto", "10px 90px"); |
| +testGridColumnsValues("gridMinContentAndAutoReversed", "20px 80px"); |
| +</script> |
| +</body> |
| +</html> |
