pdf/instance.cc - Issue 802083002: Selecting 'alt+left arrow' key in PDF does not move to previous url page. similarly 'alt+right arro…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pdf/instance.cc

Issue 802083002: Selecting 'alt+left arrow' key in PDF does not move to previous url page. similarly 'alt+right arro… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pdf/instance.cc

diff --git a/pdf/instance.cc b/pdf/instance.cc

index a8a71e8a89889b80274e4055c8dac427e9013520..6b27be4939a7f81dbaca59545bdd1b09cff35bbb 100644

--- a/pdf/instance.cc

+++ b/pdf/instance.cc

@@ -532,8 +532,10 @@ bool Instance::HandleInputEvent(const pp::InputEvent& event) {

pp::KeyboardInputEvent keyboard_event(event);

bool no_h_scrollbar = !h_scrollbar_.get();

uint32_t key_code = keyboard_event.GetKeyCode();

- bool page_down = no_h_scrollbar && key_code == ui::VKEY_RIGHT;

- bool page_up = no_h_scrollbar && key_code == ui::VKEY_LEFT;

+ bool is_modifiers = keyboard_event.GetModifiers() ? true : false;

raymes 2014/12/14 23:49:07 bool has_modifiers = keyboard_event.GetModifiers()

+ bool page_down =

+ no_h_scrollbar && !is_modifiers && key_code == ui::VKEY_RIGHT;

+ bool page_up = no_h_scrollbar && !is_modifiers && key_code == ui::VKEY_LEFT;

if (zoom_mode_ == ZOOM_FIT_TO_PAGE) {

bool has_shift =

keyboard_event.GetModifiers() & PP_INPUTEVENT_MODIFIER_SHIFTKEY;

« no previous file with comments | « no previous file | no next file » | no next file with comments »