Selecting 'alt+left arrow' key in PDF does not move to previous url page. similarly 'alt+right arro…

Selecting 'alt+left arrow' key in PDF does not move to previous url page. similarly 'alt+right arrow' key in PDF does not move to next url page.

Currently alt+arrow, ctrl+arrow,shift+arrow work like when
user select just arrow key, so with in the pdf file movement happen.
That is wrong.
It should be like:
1.Page should move up with in PDF when
 -Selecting Shift+Spacebar.
 -Selecting Pageup key.
 -Selecting only Left Arrow Key.
2.Page should move down with in PDF when
 -Selecting Spacebar.
 -Selecting Pagedown key.
 -Selecting only Right Arrow Key.

Changes added so that alt+ arrow key should have default behavior
that is moving to previous or next url.

BUG=75089
Committed: https://crrev.com/8a480e8350a8f10eaa3052a967c7998a8dadc1f8
Cr-Commit-Position: refs/heads/master@{#308511}

[Deepak, 2014-12-13 06:30:22]

deepak.m1@samsung.com changed reviewers:
+ gene@chromium.org, raymes@chromium.org

[Deepak, 2014-12-13 06:30:22]

PTAL.
Thanks

[raymes, 2014-12-14 23:49:08]

looks good with a small change

https://codereview.chromium.org/802083002/diff/1/pdf/instance.cc
File pdf/instance.cc (right):

https://codereview.chromium.org/802083002/diff/1/pdf/instance.cc#newcode535
pdf/instance.cc:535: bool is_modifiers = keyboard_event.GetModifiers() ? true :
false;
bool has_modifiers = keyboard_event.GetModifiers() != 0;

[Deepak, 2014-12-15 02:59:50]

On 2014/12/14 23:49:08, raymes wrote:
> looks good with a small change
> 
> https://codereview.chromium.org/802083002/diff/1/pdf/instance.cc
> File pdf/instance.cc (right):
> 
> https://codereview.chromium.org/802083002/diff/1/pdf/instance.cc#newcode535
> pdf/instance.cc:535: bool is_modifiers = keyboard_event.GetModifiers() ? true
:
> false;
> bool has_modifiers = keyboard_event.GetModifiers() != 0;

Thanks for review.
Changes done.
PTAL.

[raymes, 2014-12-15 05:51:00]

https://codereview.chromium.org/802083002/diff/20001/pdf/instance.cc
File pdf/instance.cc (right):

https://codereview.chromium.org/802083002/diff/20001/pdf/instance.cc#newcode535
pdf/instance.cc:535: bool is_modifiers = keyboard_event.GetModifiers() != 0;
could you rename is_modifiers to has_modifiers?

[Deepak, 2014-12-15 06:48:48]

On 2014/12/15 05:51:00, raymes wrote:
> https://codereview.chromium.org/802083002/diff/20001/pdf/instance.cc
> File pdf/instance.cc (right):
> 
>
https://codereview.chromium.org/802083002/diff/20001/pdf/instance.cc#newcode535
> pdf/instance.cc:535: bool is_modifiers = keyboard_event.GetModifiers() != 0;
> could you rename is_modifiers to has_modifiers?
Done.

Thanks for review.
Changes done.
PTAL.

[raymes, 2014-12-15 23:01:01]

lgtm

[gene, 2014-12-16 00:12:29]

lgtm

[Deepak, 2014-12-16 01:24:04]

The CQ bit was checked by deepak.m1@samsung.com

[commit-bot: I haz the power, 2014-12-16 01:25:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/802083002/40001

[commit-bot: I haz the power, 2014-12-16 02:41:06]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-12-16 02:42:46]

Patchset 3 (id:??) landed as
https://crrev.com/8a480e8350a8f10eaa3052a967c7998a8dadc1f8
Cr-Commit-Position: refs/heads/master@{#308511}