Don't schedule more invokeFunctors than necessary.

Don't schedule more invokeFunctors than necessary.

The problematic sequence of events is as follows:
1. ShouldRequestOnNonUiThread, which posts a closure
(request_draw_gl_closure_) to UI thread
2. That closure gets run on UI thread, and it schedules the invokeFunctor
with Android framework
3. Before the corresponding invokeFunctor actually happens on RT (which
is DrawGL process mode),  ShouldRequestOnUiTdread is called on the UI
thread. At this point, pending_non_ui_ is not null, we cancel the
callback, which does nothing, because WebView has already scheduled an
invokeFunctor with the Android framework in Step 2. Then we schedule
another invokeFunctor immediately on the UI thread. So there are 2
invokeFunctors queued in Android framework in this case.

This CL tries keep track of whether or not we've
queued an invokeFunctor in Android framework already.

BUG=442013
Committed: https://crrev.com/81c62e2d9601d38c44f71857dfabc31e2726cd70
Cr-Commit-Position: refs/heads/master@{#308241}

[hush (inactive), 2014-12-13 00:49:54]

hush@chromium.org changed reviewers:
+ boliu@chromium.org

[hush (inactive), 2014-12-13 00:49:54]

PTAL

[boliu, 2014-12-13 01:03:15]

https://codereview.chromium.org/801923003/diff/1/android_webview/browser/shar...
File android_webview/browser/shared_renderer_state.cc (right):

https://codereview.chromium.org/801923003/diff/1/android_webview/browser/shar...
android_webview/browser/shared_renderer_state.cc:274: if (draw_info->mode ==
AwDrawGLInfo::kModeProcess ||
nit: put it after the kModeSync check

https://codereview.chromium.org/801923003/diff/1/android_webview/browser/shar...
File android_webview/browser/shared_renderer_state.h (right):

https://codereview.chromium.org/801923003/diff/1/android_webview/browser/shar...
android_webview/browser/shared_renderer_state.h:100: bool
has_queued_functor_on_ui_;
This state should be tracked in RequestDrawGLTracker

[hush (inactive), 2014-12-13 01:17:24]

https://codereview.chromium.org/801923003/diff/1/android_webview/browser/shar...
File android_webview/browser/shared_renderer_state.cc (right):

https://codereview.chromium.org/801923003/diff/1/android_webview/browser/shar...
android_webview/browser/shared_renderer_state.cc:274: if (draw_info->mode ==
AwDrawGLInfo::kModeProcess ||
On 2014/12/13 01:03:15, boliu wrote:
> nit: put it after the kModeSync check

Done.

https://codereview.chromium.org/801923003/diff/1/android_webview/browser/shar...
File android_webview/browser/shared_renderer_state.h (right):

https://codereview.chromium.org/801923003/diff/1/android_webview/browser/shar...
android_webview/browser/shared_renderer_state.h:100: bool
has_queued_functor_on_ui_;
On 2014/12/13 01:03:15, boliu wrote:
> This state should be tracked in RequestDrawGLTracker

Right. Good point!

[hush (inactive), 2014-12-13 01:47:07]

Patchset #3 (id:40001) has been deleted

[boliu, 2014-12-13 02:02:23]

lgtm, need a crbug to merge, etc..

[hush (inactive), 2014-12-13 02:07:26]

The CQ bit was checked by hush@chromium.org

[commit-bot: I haz the power, 2014-12-13 02:08:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/801923003/60001

[commit-bot: I haz the power, 2014-12-13 03:42:39]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2014-12-13 03:43:25]

Patchset 3 (id:??) landed as
https://crrev.com/81c62e2d9601d38c44f71857dfabc31e2726cd70
Cr-Commit-Position: refs/heads/master@{#308241}