Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: pkg/analysis_server/test/domain_completion_test.dart

Issue 801863002: call dispose so completion manager can cancel pending operations (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/completion_manager.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/domain_completion_test.dart
diff --git a/pkg/analysis_server/test/domain_completion_test.dart b/pkg/analysis_server/test/domain_completion_test.dart
index 442c0ba6b4d75d1841e54d0ed7bff2bc06cac85d..ecd6e259a964e6bc13a3425fb04d75e4b9050359 100644
--- a/pkg/analysis_server/test/domain_completion_test.dart
+++ b/pkg/analysis_server/test/domain_completion_test.dart
@@ -85,7 +85,8 @@ class CompletionManagerTest extends AbstractAnalysisTest {
expect(completionDomain.manager, isNull);
sendRequest(testFile);
expect(completionDomain.manager, isNotNull);
- CompletionManager expectedManager = completionDomain.manager;
+ MockCompletionManager expectedManager = completionDomain.manager;
+ expect(expectedManager.disposeCallCount, 0);
expect(completionDomain.mockContext.mockStream.listenCount, 1);
expect(completionDomain.mockContext.mockStream.cancelCount, 0);
return pumpEventQueue().then((_) {
@@ -94,6 +95,7 @@ class CompletionManagerTest extends AbstractAnalysisTest {
sendRequest(testFile2);
expect(completionDomain.manager, isNotNull);
expect(completionDomain.manager, isNot(expectedManager));
+ expect(expectedManager.disposeCallCount, 1);
expectedManager = completionDomain.manager;
expect(completionDomain.mockContext.mockStream.listenCount, 2);
expect(completionDomain.mockContext.mockStream.cancelCount, 1);
@@ -440,6 +442,7 @@ class MockCompletionManager implements CompletionManager {
final SearchEngine searchEngine;
StreamController<CompletionResult> controller;
int computeCallCount = 0;
+ int disposeCallCount = 0;
MockCompletionManager(this.context, this.source, this.searchEngine);
@@ -456,6 +459,11 @@ class MockCompletionManager implements CompletionManager {
}
@override
+ void dispose() {
+ ++disposeCallCount;
+ }
+
+ @override
Stream<CompletionResult> results(CompletionRequest request) {
controller = new StreamController<CompletionResult>(onListen: () {
scheduleMicrotask(() {
« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/completion_manager.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698