Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Unified Diff: pkg/analysis_server/lib/src/services/completion/completion_manager.dart

Issue 801863002: call dispose so completion manager can cancel pending operations (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/completion/completion_manager.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/completion_manager.dart b/pkg/analysis_server/lib/src/services/completion/completion_manager.dart
index c66da42a8885d3654a83fc6380bcfe79c3786218..a8d16db64cbc37de62bd1182d50e6ff8a9505d78 100644
--- a/pkg/analysis_server/lib/src/services/completion/completion_manager.dart
+++ b/pkg/analysis_server/lib/src/services/completion/completion_manager.dart
@@ -92,6 +92,13 @@ abstract class CompletionManager {
void computeSuggestions(CompletionRequest request);
/**
+ * Discard any pending operations.
+ * Subclasses may override but should call super.dispose
+ */
+ void dispose() {
+ }
+
+ /**
* Generate a stream of code completion results.
*/
Stream<CompletionResult> results(CompletionRequest request) {
« no previous file with comments | « pkg/analysis_server/lib/src/domain_completion.dart ('k') | pkg/analysis_server/test/domain_completion_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698