Improve LayoutTest output for Errors

LayoutTests/crypto/ecdh-deriveBits-failures-expected.txt

Index: LayoutTests/crypto/ecdh-deriveBits-failures-expected.txt
diff --git a/LayoutTests/crypto/ecdh-deriveBits-failures-expected.txt b/LayoutTests/crypto/ecdh-deriveBits-failures-expected.txt
index 38a3e45f9ef6ace19086d89c038c717bb8571544..b318d82dd3a3f83a3ed459628d53c482daa2703c 100644
--- a/LayoutTests/crypto/ecdh-deriveBits-failures-expected.txt
+++ b/LayoutTests/crypto/ecdh-deriveBits-failures-expected.txt
@@ -3,15 +3,34 @@ Tests bad inputs to ECDH's deriveBits()
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
+deriveBits() without algorithm name or public key...
 error is: TypeError: Algorithm: name: Missing or not a string
+
+deriveBits() without public key...
 error is: TypeError: EcdhKeyDeriveParams: public: Missing required property
+
+deriveBits() with algorithm that is null...
 error is: TypeError: Algorithm: Not an object
+
+deriveBits() with algorithm that is -1...
 error is: NotSupportedError: Algorithm: Unrecognized name
+
+deriveBits() with public key that is null...
 error is: TypeError: EcdhKeyDeriveParams: public: Must be a CryptoKey
+
+deriveBits() with public key that is -1...
 error is: TypeError: EcdhKeyDeriveParams: public: Must be a CryptoKey
+
+deriveBits() with public key that is a string...
 error is: TypeError: EcdhKeyDeriveParams: public: Must be a CryptoKey
+
+deriveBits() with wrong curve public key...
 error is: InvalidAccessError: The public parameter for ECDH key derivation is for a different named curve
+
+deriveBits() with private key as public key...

[eroman, 2014/12/15 22:35:38]

It doesn't look like this expectation has been updated to reflect the changes
you made in the accompanying HTML.

Once this is fixed, LGTM.

If you are building on Linux the steps are somewhat annoying:

  (1) Build the BoringSSL version of WebCrypto:

    # Re-generate the ninja files (i.e. makefiles)
    $ GYP_DEFINES="use_openssl=1" ./build/gyp_chromium
    $ ninja -C out/Debug blink_tests

  (2) Temporarily edit the LayoutTests/TestExpectation file by deleting all of
the crypto/ lines (otherwise failures on Linux will be accepted as working)

  (3) Regenerate baselines with:

     ./Tool/Script/run-webkit-tests --debug --reset-results crypto

Cheers

[Paritosh Kumar, 2014/12/16 07:24:22]

Apologize.

Thanks. Done.

 error is: InvalidAccessError: The public parameter for ECDH key derivation is not a public EC key
+
+deriveBits() with public key that is for ECDSA...
 error is: InvalidAccessError: The public parameter for ECDH key derivation must be for ECDH
 PASS successfullyParsed is true