LayoutTests/crypto/aes-cbc-generateKey-parseAlgorithm-failures.html - Issue 801793003: Improve LayoutTest output for Errors

Side by Side Diff: LayoutTests/crypto/aes-cbc-generateKey-parseAlgorithm-failures.html

Issue 801793003: Improve LayoutTest output for Errors (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | LayoutTests/crypto/aes-cbc-generateKey-parseAlgorithm-failures-expected.txt » ('j') | LayoutTests/crypto/aes-cbc-parseAlgorithm-failures.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="../resources/js-test.js"></script>	4 <script src="../resources/js-test.js"></script>

5 <script src="resources/common.js"></script>	5 <script src="resources/common.js"></script>

6 </head>	6 </head>

7 <body>	7 <body>

8 <p id="description"></p>	8 <p id="description"></p>

9 <div id="console"></div>	9 <div id="console"></div>

10	10

11 <script>	11 <script>

12 description("Tests generateKey() with bad AES-CBC parameters.");	12 description("Tests generateKey() with bad AES-CBC parameters.");

13 jsTestIsAsync = true;	13 jsTestIsAsync = true;

14	14

15 extractable = true;	15 extractable = true;

16 keyUsages = ['encrypt', 'decrypt'];	16 keyUsages = ['encrypt', 'decrypt'];

17	17

18 Promise.resolve(null).then(function() {	18 Promise.resolve(null).then(function() {

19 // Invalid keyUsages	19 // Invalid keyUsages
	eroman 2014/12/12 19:37:01 Can you remove the comments? (They add no value no Can you remove the comments? (They add no value now that there is a debug message with even more detail). Paritosh Kumar 2014/12/15 08:21:26 Done. Show quoted text On 2014/12/12 19:37:01, eroman wrote: > Can you remove the comments? (They add no value now that there is a debug > message with even more detail). Done.
	20 debug("\ngenerateKey() with invalid keyUsages value that is -1...");

20 return crypto.subtle.generateKey({ name: 'aes-cbc', length: 1024 }, extracta ble, -1);	21 return crypto.subtle.generateKey({ name: 'aes-cbc', length: 1024 }, extracta ble, -1);

21 }).then(failAndFinishJSTest, function(result) {	22 }).then(failAndFinishJSTest, function(result) {

22 logError(result);	23 logError(result);

23	24

24 // Invalid keyUsages	25 // Invalid keyUsages

	26 debug("\ngenerateKey() with invalid keyUsages value that is null...");

25 return crypto.subtle.generateKey({ name: 'aes-cbc', length: 1024 }, extracta ble, null);	27 return crypto.subtle.generateKey({ name: 'aes-cbc', length: 1024 }, extracta ble, null);

26 }).then(failAndFinishJSTest, function(result) {	28 }).then(failAndFinishJSTest, function(result) {

27 logError(result);	29 logError(result);

28	30

29 // Bad key usage "boo".	31 // Bad key usage "boo".

	32 debug("\ngenerateKey() with bad keyUsages value that is a string...");
	eroman 2014/12/12 19:37:01 "generateKey() with an invalid key usage of 'boo'" "generateKey() with an invalid key usage of 'boo'" Paritosh Kumar 2014/12/15 08:21:26 Done. Show quoted text On 2014/12/12 19:37:01, eroman wrote: > "generateKey() with an invalid key usage of 'boo'" Done.
30 return crypto.subtle.generateKey({ name: 'aes-cbc', length: 1024 }, extracta ble, ['boo']);	33 return crypto.subtle.generateKey({ name: 'aes-cbc', length: 1024 }, extracta ble, ['boo']);

31 }).then(failAndFinishJSTest, function(result) {	34 }).then(failAndFinishJSTest, function(result) {

32 logError(result);	35 logError(result);

33	36

	37 debug("\ngenerateKey() without length...");

34 return crypto.subtle.generateKey({ name: 'aes-cbc' }, extractable, keyUsages );	38 return crypto.subtle.generateKey({ name: 'aes-cbc' }, extractable, keyUsages );

35 }).then(failAndFinishJSTest, function(result) {	39 }).then(failAndFinishJSTest, function(result) {

36 logError(result);	40 logError(result);

37	41

	42 debug("\ngenerateKey() with length larger than range...");
	eroman 2014/12/12 19:37:01 "generateKey() with a length of 70000" I think th "generateKey() with a length of 70000" I think there is value in specifying the exact numeric value, since part of looking at text expectations it to verify that the range enforcement is correct. Paritosh Kumar 2014/12/15 08:21:26 Done. Show quoted text On 2014/12/12 19:37:01, eroman wrote: > "generateKey() with a length of 70000" > > I think there is value in specifying the exact numeric value, since part of > looking at text expectations it to verify that the range enforcement is correct. Done.
38 return crypto.subtle.generateKey({ name: 'aes-cbc', length: 70000 }, extract able, keyUsages);	43 return crypto.subtle.generateKey({ name: 'aes-cbc', length: 70000 }, extract able, keyUsages);

39 }).then(failAndFinishJSTest, function(result) {	44 }).then(failAndFinishJSTest, function(result) {

40 logError(result);	45 logError(result);

41	46

	47 debug("\ngenerateKey() with negative length...");
	eroman 2014/12/12 19:37:01 generateKey() with a length of -3 generateKey() with a length of -3 Paritosh Kumar 2014/12/15 08:21:26 Done. Show quoted text On 2014/12/12 19:37:01, eroman wrote: > generateKey() with a length of -3 Done.
42 return crypto.subtle.generateKey({ name: 'aes-cbc', length: -3 }, extractabl e, keyUsages);	48 return crypto.subtle.generateKey({ name: 'aes-cbc', length: -3 }, extractabl e, keyUsages);

43 }).then(failAndFinishJSTest, function(result) {	49 }).then(failAndFinishJSTest, function(result) {

44 logError(result);	50 logError(result);

45	51

	52 debug("\ngenerateKey() with length that is minus Infinity...");

46 return crypto.subtle.generateKey({ name: 'aes-cbc', length: -Infinity }, ext ractable, keyUsages);	53 return crypto.subtle.generateKey({ name: 'aes-cbc', length: -Infinity }, ext ractable, keyUsages);

47 }).then(failAndFinishJSTest, function(result) {	54 }).then(failAndFinishJSTest, function(result) {

48 logError(result);	55 logError(result);

49 }).then(finishJSTest, failAndFinishJSTest);	56 }).then(finishJSTest, failAndFinishJSTest);

50	57

51 </script>	58 </script>

52	59

53 </body>	60 </body>

54 </html>	61 </html>

OLD	NEW