Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: LayoutTests/crypto/aes-cbc-generateKey-parseAlgorithm-failures.html

Issue 801793003: Improve LayoutTest output for Errors (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/crypto/aes-cbc-generateKey-parseAlgorithm-failures.html
diff --git a/LayoutTests/crypto/aes-cbc-generateKey-parseAlgorithm-failures.html b/LayoutTests/crypto/aes-cbc-generateKey-parseAlgorithm-failures.html
index ef0b91de105df66862982e4550f0765664494914..0c8e6275df8aefa3350c85be255a7b4f65df6ea8 100644
--- a/LayoutTests/crypto/aes-cbc-generateKey-parseAlgorithm-failures.html
+++ b/LayoutTests/crypto/aes-cbc-generateKey-parseAlgorithm-failures.html
@@ -17,32 +17,39 @@ keyUsages = ['encrypt', 'decrypt'];
Promise.resolve(null).then(function() {
// Invalid keyUsages
eroman 2014/12/12 19:37:01 Can you remove the comments? (They add no value no
Paritosh Kumar 2014/12/15 08:21:26 Done.
+ debug("\ngenerateKey() with invalid keyUsages value that is -1...");
return crypto.subtle.generateKey({ name: 'aes-cbc', length: 1024 }, extractable, -1);
}).then(failAndFinishJSTest, function(result) {
logError(result);
// Invalid keyUsages
+ debug("\ngenerateKey() with invalid keyUsages value that is null...");
return crypto.subtle.generateKey({ name: 'aes-cbc', length: 1024 }, extractable, null);
}).then(failAndFinishJSTest, function(result) {
logError(result);
// Bad key usage "boo".
+ debug("\ngenerateKey() with bad keyUsages value that is a string...");
eroman 2014/12/12 19:37:01 "generateKey() with an invalid key usage of 'boo'"
Paritosh Kumar 2014/12/15 08:21:26 Done.
return crypto.subtle.generateKey({ name: 'aes-cbc', length: 1024 }, extractable, ['boo']);
}).then(failAndFinishJSTest, function(result) {
logError(result);
+ debug("\ngenerateKey() without length...");
return crypto.subtle.generateKey({ name: 'aes-cbc' }, extractable, keyUsages);
}).then(failAndFinishJSTest, function(result) {
logError(result);
+ debug("\ngenerateKey() with length larger than range...");
eroman 2014/12/12 19:37:01 "generateKey() with a length of 70000" I think th
Paritosh Kumar 2014/12/15 08:21:26 Done.
return crypto.subtle.generateKey({ name: 'aes-cbc', length: 70000 }, extractable, keyUsages);
}).then(failAndFinishJSTest, function(result) {
logError(result);
+ debug("\ngenerateKey() with negative length...");
eroman 2014/12/12 19:37:01 generateKey() with a length of -3
Paritosh Kumar 2014/12/15 08:21:26 Done.
return crypto.subtle.generateKey({ name: 'aes-cbc', length: -3 }, extractable, keyUsages);
}).then(failAndFinishJSTest, function(result) {
logError(result);
+ debug("\ngenerateKey() with length that is minus Infinity...");
return crypto.subtle.generateKey({ name: 'aes-cbc', length: -Infinity }, extractable, keyUsages);
}).then(failAndFinishJSTest, function(result) {
logError(result);

Powered by Google App Engine
This is Rietveld 408576698