Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 801603002: Add support for command line switches to Features, and as proof that it works, (Closed)

Created:
6 years ago by not at google - send to devlin
Modified:
6 years ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add support for command line switches to Features, and as proof that it works, use it for the experimental permission. BUG=440194 R=rockot@chromium.org Committed: https://crrev.com/ae342c9a0fa8a3c55bc89bf9a1543ad85f7d404f Cr-Commit-Position: refs/heads/master@{#308176}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : tests #

Patch Set 4 : rebase #

Patch Set 5 : work #

Patch Set 6 : test fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -66 lines) Patch
M chrome/browser/extensions/crx_installer_browsertest.cc View 1 2 6 chunks +64 lines, -19 lines 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_experimental_unittest.cc View 1 2 3 4 5 1 chunk +4 lines, -1 line 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_isolatedapp_unittest.cc View 1 2 3 4 5 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc View 1 2 3 4 5 1 chunk +5 lines, -3 lines 0 comments Download
M extensions/common/features/feature.h View 2 chunks +12 lines, -0 lines 0 comments Download
M extensions/common/features/feature.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M extensions/common/features/simple_feature.h View 3 chunks +11 lines, -6 lines 0 comments Download
M extensions/common/features/simple_feature.cc View 4 chunks +20 lines, -2 lines 0 comments Download
M extensions/common/features/simple_feature_unittest.cc View 1 3 chunks +50 lines, -0 lines 0 comments Download
M extensions/common/manifest_constants.h View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M extensions/common/manifest_constants.cc View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/common/manifest_handlers/permissions_parser.cc View 3 chunks +10 lines, -27 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
not at google - send to devlin
Alright, here we go. Now, this does actually change the behaviour of installing off-store Extensions ...
6 years ago (2014-12-12 01:38:00 UTC) #2
Ken Rockot(use gerrit already)
lgtm
6 years ago (2014-12-12 02:17:04 UTC) #3
Ken Rockot(use gerrit already)
On 2014/12/12 02:17:04, Ken Rockot wrote: > lgtm (barring what i assume are just merge ...
6 years ago (2014-12-12 02:17:16 UTC) #4
not at google - send to devlin
On 2014/12/12 02:17:16, Ken Rockot wrote: > On 2014/12/12 02:17:04, Ken Rockot wrote: > > ...
6 years ago (2014-12-12 17:49:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/801603002/80001
6 years ago (2014-12-12 17:51:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/801603002/100001
6 years ago (2014-12-12 17:58:36 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/17751) mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/14248)
6 years ago (2014-12-12 18:53:24 UTC) #11
not at google - send to devlin
Well, this CL became more about making the experimental permission a warning rather than an ...
6 years ago (2014-12-12 20:25:58 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/801603002/120001
6 years ago (2014-12-12 20:27:17 UTC) #14
commit-bot: I haz the power
Committed patchset #6 (id:120001)
6 years ago (2014-12-12 22:04:38 UTC) #15
commit-bot: I haz the power
6 years ago (2014-12-12 22:05:22 UTC) #16
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/ae342c9a0fa8a3c55bc89bf9a1543ad85f7d404f
Cr-Commit-Position: refs/heads/master@{#308176}

Powered by Google App Engine
This is Rietveld 408576698