chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc - Issue 801603002: Add support for command line switches to Features, and as proof that it works,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc

Issue 801603002: Add support for command line switches to Features, and as proof that it works, (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: test fixes Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_tests/extension_manifests_isolatedapp_unittest.cc ('k') | extensions/common/features/feature.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc

diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc

index 296030c09d2cb7ea284e9597184b632f6da1ea04..99b57b10f7ecebe57c7eec6bff81b7b8c6a44787 100644

--- a/chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc

+++ b/chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc

@@ -129,10 +129,12 @@ TEST_F(PlatformAppsManifestTest, CertainApisRequirePlatformApps) {

manifests.push_back(make_linked_ptr(manifest->DeepCopy()));

}

- // First try to load without any flags. This should fail for every API.

+ // First try to load without any flags. This should warn for every API.

for (size_t i = 0; i < arraysize(kPlatformAppExperimentalApis); ++i) {

- LoadAndExpectError(ManifestData(manifests[i].get(), ""),

- errors::kExperimentalFlagRequired);

+ LoadAndExpectWarning(

+ ManifestData(manifests[i].get(), ""),

+ "'experimental' requires the 'experimental-extension-apis' "

+ "command line switch to be enabled.");

}

// Now try again with the experimental flag set.