Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Issue 801523002: Bundle the DEPS of mojom_bindings_generator.py with the public SDK. (Closed)

Created:
6 years ago by blundell
Modified:
6 years ago
Reviewers:
viettrungluu
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Bundle the DEPS of mojom_bindings_generator.py with the public SDK. The rationale for this bundling is the following: - Every client of the public SDK will need these deps to process the mojoms in the public SDK. - These deps are not something that clients will already have in general (as opposed to say a C++ compiler). - Even if the client happens to already have these deps, by packaging the versions that mojom_bindings_generator.py is interfaced against we make mojom_bindings_generator.py hermetic. Note that the versions of these modules in //third_party are left there because there are other internal dependencies on them throughout the repo. R=viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/91de5b1bc985e403666d6cb45d4ba49789192eb5

Patch Set 1 #

Patch Set 2 : nits #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-35 lines, --37 lines) Patch
A mojo/public/third_party/README.txt View 1 chunk +2 lines, -0 lines 0 comments Download
A + mojo/public/third_party/jinja2/AUTHORS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/third_party/jinja2/Jinja2-2.7.1.tar.gz.md5 View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/third_party/jinja2/Jinja2-2.7.1.tar.gz.sha512 View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/third_party/jinja2/LICENSE View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/third_party/jinja2/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/third_party/jinja2/README.chromium View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/third_party/jinja2/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/third_party/jinja2/_compat.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/third_party/jinja2/_stringdefs.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/third_party/jinja2/bccache.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/third_party/jinja2/compiler.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/third_party/jinja2/constants.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/third_party/jinja2/debug.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/third_party/jinja2/defaults.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/third_party/jinja2/environment.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/third_party/jinja2/exceptions.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/third_party/jinja2/ext.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/third_party/jinja2/filters.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/third_party/jinja2/get_jinja2.sh View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/third_party/jinja2/lexer.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/third_party/jinja2/loaders.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/third_party/jinja2/meta.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/third_party/jinja2/nodes.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/third_party/jinja2/optimizer.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/third_party/jinja2/parser.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/third_party/jinja2/runtime.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/third_party/jinja2/sandbox.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/third_party/jinja2/tests.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/third_party/jinja2/utils.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/third_party/jinja2/visitor.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/third_party/markupsafe/AUTHORS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/third_party/markupsafe/LICENSE View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/third_party/markupsafe/MarkupSafe-0.18.tar.gz.md5 View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/third_party/markupsafe/MarkupSafe-0.18.tar.gz.sha512 View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/third_party/markupsafe/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/third_party/markupsafe/README.chromium View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/third_party/markupsafe/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/third_party/markupsafe/_compat.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/third_party/markupsafe/_constants.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/third_party/markupsafe/_native.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/third_party/markupsafe/_speedups.c View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/third_party/markupsafe/get_markupsafe.sh View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/third_party/ply/LICENSE View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/third_party/ply/README View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/third_party/ply/README.chromium View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/third_party/ply/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/third_party/ply/lex.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/third_party/ply/yacc.py View 0 chunks +-1 lines, --1 lines 0 comments Download
M mojo/public/tools/bindings/mojom.gni View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/mojom_bindings_generator.gypi View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/mojom_bindings_generator.py View 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/public/tools/bindings/mojom_bindings_generator_explicit.gypi View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/generate/template_expander.py View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/parse/lexer.py View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/parse/parser.py View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/pylib/mojom_tests/parse/lexer_unittest.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
viettrungluu
Probably we can make it mojom_bindings_generator.py always use the bundled libraries, but we can do ...
6 years ago (2014-12-11 22:38:46 UTC) #5
blundell
On 2014/12/11 22:38:46, viettrungluu wrote: > Probably we can make it mojom_bindings_generator.py always use the ...
6 years ago (2014-12-12 07:14:06 UTC) #6
blundell
6 years ago (2014-12-12 07:14:34 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
91de5b1bc985e403666d6cb45d4ba49789192eb5.

Powered by Google App Engine
This is Rietveld 408576698