Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 801283003: Regression: Add back support for hr elements in select listbox (Closed)

Created:
6 years ago by keishi
Modified:
6 years ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-css, blink-reviews-html_chromium.org, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis
Project:
blink
Visibility:
Public.

Description

Regression: Add back support for hr elements in select listbox Regression caused by r178354. BUG=346582 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187221

Patch Set 1 #

Patch Set 2 : Fixed test expectations #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -5 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +2 lines, -0 lines 0 comments Download
A LayoutTests/fast/forms/select/listbox-appearance-separator.html View 1 chunk +25 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/suggested-value-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/forms/suggested-value-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win/fast/forms/suggested-value-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/html.css View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/html/HTMLOptGroupElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
keishi
6 years ago (2014-12-15 08:32:02 UTC) #2
tkent
lgtm
6 years ago (2014-12-15 08:41:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/801283003/1
6 years ago (2014-12-15 08:42:54 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/41737)
6 years ago (2014-12-15 10:13:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/801283003/40001
6 years ago (2014-12-16 03:58:56 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-16 05:43:10 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187221

Powered by Google App Engine
This is Rietveld 408576698