Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Side by Side Diff: Source/core/html/HTMLSelectElement.cpp

Issue 801283003: Regression: Add back support for hr elements in select listbox (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/html/HTMLOptGroupElement.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
4 * (C) 1999 Antti Koivisto (koivisto@kde.org) 4 * (C) 1999 Antti Koivisto (koivisto@kde.org)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved.
7 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 7 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 9 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
10 * 10 *
(...skipping 1745 matching lines...) Expand 10 before | Expand all | Expand 10 after
1756 { 1756 {
1757 #if ENABLE(OILPAN) 1757 #if ENABLE(OILPAN)
1758 visitor->trace(m_listItems); 1758 visitor->trace(m_listItems);
1759 #endif 1759 #endif
1760 HTMLFormControlElementWithState::trace(visitor); 1760 HTMLFormControlElementWithState::trace(visitor);
1761 } 1761 }
1762 1762
1763 void HTMLSelectElement::didAddUserAgentShadowRoot(ShadowRoot& root) 1763 void HTMLSelectElement::didAddUserAgentShadowRoot(ShadowRoot& root)
1764 { 1764 {
1765 RefPtrWillBeRawPtr<HTMLContentElement> content = HTMLContentElement::create( document()); 1765 RefPtrWillBeRawPtr<HTMLContentElement> content = HTMLContentElement::create( document());
1766 content->setAttribute(selectAttr, "option,optgroup"); 1766 content->setAttribute(selectAttr, "option,optgroup,hr");
1767 root.appendChild(content); 1767 root.appendChild(content);
1768 } 1768 }
1769 1769
1770 HTMLOptionElement* HTMLSelectElement::spatialNavigationFocusedOption() 1770 HTMLOptionElement* HTMLSelectElement::spatialNavigationFocusedOption()
1771 { 1771 {
1772 if (!isSpatialNavigationEnabled(document().frame())) 1772 if (!isSpatialNavigationEnabled(document().frame()))
1773 return nullptr; 1773 return nullptr;
1774 int focusedIndex = activeSelectionEndListIndex(); 1774 int focusedIndex = activeSelectionEndListIndex();
1775 if (focusedIndex < 0) 1775 if (focusedIndex < 0)
1776 focusedIndex = firstSelectableListIndex(); 1776 focusedIndex = firstSelectableListIndex();
1777 if (focusedIndex < 0) 1777 if (focusedIndex < 0)
1778 return nullptr; 1778 return nullptr;
1779 HTMLElement* focused = listItems()[focusedIndex]; 1779 HTMLElement* focused = listItems()[focusedIndex];
1780 return isHTMLOptionElement(focused) ? toHTMLOptionElement(focused) : nullptr ; 1780 return isHTMLOptionElement(focused) ? toHTMLOptionElement(focused) : nullptr ;
1781 } 1781 }
1782 1782
1783 } // namespace 1783 } // namespace
OLDNEW
« no previous file with comments | « Source/core/html/HTMLOptGroupElement.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698