Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 801283002: [bindings] Make Crypto.getRandomValues use generated binding rather than using custom binding. (Closed)

Created:
6 years ago by vivekg_samsung
Modified:
6 years ago
CC:
arv+blink, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[bindings] Make Crypto.getRandomValues use generated binding rather than using custom binding. This CL makes the method getRandomValues use the generated bindings over using the custom binding. In doing so the method Crypto::getRandomValues() needs to return the DOMArrayBufferView*. This CL also adds couple of missing type check tests which otherwise is a non-reachable code in the current code. R=haraken@chromium.org R=jl@opera.com BUG=345519 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187125

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -71 lines) Patch
M LayoutTests/crypto/random-values-types-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/crypto/resources/random-values-types.js View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/crypto/worker-random-values-types-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
D Source/bindings/modules/v8/custom/V8CryptoCustom.cpp View 1 chunk +0 lines, -63 lines 0 comments Download
M Source/bindings/modules/v8/custom/custom.gni View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/modules/v8/custom/custom.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/crypto/Crypto.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/crypto/Crypto.cpp View 1 chunk +5 lines, -4 lines 0 comments Download
M Source/modules/crypto/Crypto.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
vivekg
PTAL, thanks!
6 years ago (2014-12-15 07:12:29 UTC) #2
Jens Widell
LGTM
6 years ago (2014-12-15 07:16:08 UTC) #3
vivekg
Reported bot failures are unrelated to the change.
6 years ago (2014-12-15 07:23:31 UTC) #4
haraken
LGTM
6 years ago (2014-12-15 07:40:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/801283002/1
6 years ago (2014-12-15 08:09:49 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=187125
6 years ago (2014-12-15 10:46:26 UTC) #8
eroman
6 years ago (2014-12-15 19:37:53 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698