Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Unified Diff: Source/bindings/modules/v8/custom/V8CryptoCustom.cpp

Issue 801283002: [bindings] Make Crypto.getRandomValues use generated binding rather than using custom binding. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/modules/v8/custom/V8CryptoCustom.cpp
diff --git a/Source/bindings/modules/v8/custom/V8CryptoCustom.cpp b/Source/bindings/modules/v8/custom/V8CryptoCustom.cpp
deleted file mode 100644
index 02eb7b4ac1ca743da62e67a31d5ff72bc934da95..0000000000000000000000000000000000000000
--- a/Source/bindings/modules/v8/custom/V8CryptoCustom.cpp
+++ /dev/null
@@ -1,63 +0,0 @@
-/*
- * Copyright (C) 2012 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- * notice, this list of conditions and the following disclaimer in the
- * documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND ANY
- * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
- * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
- * DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR ANY
- * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
- * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
- * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
- * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
- * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#include "config.h"
-#include "bindings/modules/v8/V8Crypto.h"
-
-#include "bindings/core/v8/ExceptionMessages.h"
-#include "bindings/core/v8/ExceptionState.h"
-#include "bindings/core/v8/V8ArrayBufferView.h"
-#include "bindings/core/v8/V8Binding.h"
-#include "core/dom/ExceptionCode.h"
-#include "modules/crypto/Crypto.h"
-
-namespace blink {
-
-void V8Crypto::getRandomValuesMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
-{
- ExceptionState exceptionState(ExceptionState::ExecutionContext, "getRandomValues", "Crypto", info.Holder(), info.GetIsolate());
- if (info.Length() < 1) {
- exceptionState.throwTypeError(ExceptionMessages::notEnoughArguments(1, info.Length()));
- exceptionState.throwIfNeeded();
- return;
- }
-
- v8::Local<v8::Value> buffer = info[0];
- if (!V8ArrayBufferView::hasInstance(buffer, info.GetIsolate())) {
- exceptionState.throwTypeError("First argument is not an ArrayBufferView");
- } else {
- DOMArrayBufferView* arrayBufferView = V8ArrayBufferView::toImpl(v8::Local<v8::Object>::Cast(buffer));
- ASSERT(arrayBufferView);
-
- Crypto* crypto = V8Crypto::toImpl(info.Holder());
- crypto->getRandomValues(arrayBufferView, exceptionState);
- }
-
- if (exceptionState.throwIfNeeded())
- return;
-
- v8SetReturnValue(info, buffer);
-}
-
-} // namespace blink
« no previous file with comments | « LayoutTests/crypto/worker-random-values-types-expected.txt ('k') | Source/bindings/modules/v8/custom/custom.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698