Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 800993002: Even more win64 warning fixes (Closed)

Created:
6 years ago by bsalomon
Modified:
6 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 3

Patch Set 3 : fixes #

Patch Set 4 : more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -56 lines) Patch
M src/gpu/gl/GrGpuGL.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/images/SkImageDecoder_libico.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/opts/SkTextureCompression_opts_neon.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/opts/SkTextureCompression_opts_neon.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M src/pdf/SkPDFFont.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/utils/SkTextureCompressor.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/utils/SkTextureCompressor.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/utils/SkTextureCompressor_ASTC.h View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/SkTextureCompressor_ASTC.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M src/utils/SkTextureCompressor_LATC.h View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/SkTextureCompressor_LATC.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M src/utils/SkTextureCompressor_R11EAC.h View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/SkTextureCompressor_R11EAC.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M tests/ImageCacheTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PackBitsTest.cpp View 1 2 3 4 chunks +5 lines, -5 lines 0 comments Download
M tests/PathTest.cpp View 1 2 3 15 chunks +15 lines, -15 lines 0 comments Download
M tests/ScalarTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/ToUnicodeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (6 generated)
bsalomon
6 years ago (2014-12-12 20:03:30 UTC) #2
mtklein
lgtm https://codereview.chromium.org/800993002/diff/20001/src/utils/SkTextureCompressor.cpp File src/utils/SkTextureCompressor.cpp (right): https://codereview.chromium.org/800993002/diff/20001/src/utils/SkTextureCompressor.cpp#newcode28 src/utils/SkTextureCompressor.cpp:28: return 0 == etc1_encode_image(src, width, height, 2, SkToInt(rowBytes), ...
6 years ago (2014-12-12 20:34:08 UTC) #3
bsalomon
https://codereview.chromium.org/800993002/diff/20001/src/utils/SkTextureCompressor.cpp File src/utils/SkTextureCompressor.cpp (right): https://codereview.chromium.org/800993002/diff/20001/src/utils/SkTextureCompressor.cpp#newcode28 src/utils/SkTextureCompressor.cpp:28: return 0 == etc1_encode_image(src, width, height, 2, SkToInt(rowBytes), dst); ...
6 years ago (2014-12-12 20:39:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/800993002/20001
6 years ago (2014-12-12 20:40:35 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot/builds/1125)
6 years ago (2014-12-12 20:42:57 UTC) #8
mtklein
https://codereview.chromium.org/800993002/diff/20001/src/utils/SkTextureCompressor.cpp File src/utils/SkTextureCompressor.cpp (right): https://codereview.chromium.org/800993002/diff/20001/src/utils/SkTextureCompressor.cpp#newcode28 src/utils/SkTextureCompressor.cpp:28: return 0 == etc1_encode_image(src, width, height, 2, SkToInt(rowBytes), dst); ...
6 years ago (2014-12-12 20:43:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/800993002/40001
6 years ago (2014-12-12 22:44:45 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot/builds/1138) Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot/builds/1138)
6 years ago (2014-12-12 22:46:27 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/800993002/60001
6 years ago (2014-12-12 23:02:45 UTC) #15
commit-bot: I haz the power
6 years ago (2014-12-12 23:11:22 UTC) #16
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/9880607151ca7c2dc6b1a4b9756938bd71913ab5

Powered by Google App Engine
This is Rietveld 408576698