Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 800933002: Turns on smart deployment of the virtual keyboard by default, and changes the flag to allow easy di… (Closed)

Created:
6 years ago by rsadam
Modified:
6 years ago
Reviewers:
flackr, Mark P, sadrul, sky
CC:
chromium-reviews, sadrul, stevenjb+watch_chromium.org, asvitkine+watch_chromium.org, oshima+watch_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Turns on smart deployment of the virtual keyboard by default, and changes the flag to allow easy disabling of this feature. BUG=441814 Committed: https://crrev.com/47e23d2c8d8611f87b6de3b8f5f3b3c4a3307577 Cr-Commit-Position: refs/heads/master@{#308373}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Keep old flag in histograms. #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Total comments: 2

Patch Set 5 : Address reviewer feedback. #

Total comments: 2

Patch Set 6 : Move to anon. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -25 lines) Patch
M ash/system/chromeos/virtual_keyboard/tray_keyboard_lock_unittest.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M ash/virtual_keyboard_controller.cc View 1 2 3 4 5 3 chunks +12 lines, -8 lines 0 comments Download
M ash/virtual_keyboard_controller_unittest.cc View 1 2 3 2 chunks +7 lines, -3 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download
M ui/keyboard/keyboard_switches.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/keyboard/keyboard_switches.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (5 generated)
rsadam
Hi Flackr, PTAL!
6 years ago (2014-12-12 17:46:31 UTC) #2
rsadam
+mpearson for histogram OWNERS
6 years ago (2014-12-12 17:47:15 UTC) #4
Mark P
https://codereview.chromium.org/800933002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/800933002/diff/1/tools/metrics/histograms/histograms.xml#oldcode49050 tools/metrics/histograms/histograms.xml:49050: - <int value="2121776031" label="auto-virtual-keyboard"/> Please leave the old command ...
6 years ago (2014-12-12 18:00:49 UTC) #5
rsadam
Restored old entry in histograms.xml, and updated new one to correct id.
6 years ago (2014-12-12 18:16:00 UTC) #6
Mark P
histograms.xml lgtm
6 years ago (2014-12-12 18:18:50 UTC) #7
rsadam
+sadrul for ash/*, ui/* OWNERS
6 years ago (2014-12-12 21:16:44 UTC) #9
sadrul
LGTM https://codereview.chromium.org/800933002/diff/30001/ash/virtual_keyboard_controller_unittest.cc File ash/virtual_keyboard_controller_unittest.cc (right): https://codereview.chromium.org/800933002/diff/30001/ash/virtual_keyboard_controller_unittest.cc#newcode77 ash/virtual_keyboard_controller_unittest.cc:77: UpdateTouchscreenDevices(std::vector<ui::TouchscreenDevice>()); Add a comment explaining why these are ...
6 years ago (2014-12-12 21:22:44 UTC) #10
flackr
This CL LGTM, but the auto deployment is still broken in ozone isn't it? (http://crbug.com/437539). ...
6 years ago (2014-12-12 21:24:21 UTC) #11
rsadam
On 2014/12/12 21:24:21, flackr wrote: > This CL LGTM, but the auto deployment is still ...
6 years ago (2014-12-12 22:05:38 UTC) #12
rsadam
+Sky for ash/virtual_keyboard* OWNERS https://codereview.chromium.org/800933002/diff/30001/ash/virtual_keyboard_controller_unittest.cc File ash/virtual_keyboard_controller_unittest.cc (right): https://codereview.chromium.org/800933002/diff/30001/ash/virtual_keyboard_controller_unittest.cc#newcode77 ash/virtual_keyboard_controller_unittest.cc:77: UpdateTouchscreenDevices(std::vector<ui::TouchscreenDevice>()); On 2014/12/12 21:22:44, sadrul ...
6 years ago (2014-12-12 22:10:22 UTC) #14
sky
https://codereview.chromium.org/800933002/diff/50001/ash/virtual_keyboard_controller.cc File ash/virtual_keyboard_controller.cc (right): https://codereview.chromium.org/800933002/diff/50001/ash/virtual_keyboard_controller.cc#newcode40 ash/virtual_keyboard_controller.cc:40: keyboard::switches::kDisableSmartVirtualKeyboard)) { Can we have this check in one ...
6 years ago (2014-12-13 00:12:24 UTC) #15
rsadam
https://codereview.chromium.org/800933002/diff/50001/ash/virtual_keyboard_controller.cc File ash/virtual_keyboard_controller.cc (right): https://codereview.chromium.org/800933002/diff/50001/ash/virtual_keyboard_controller.cc#newcode40 ash/virtual_keyboard_controller.cc:40: keyboard::switches::kDisableSmartVirtualKeyboard)) { On 2014/12/13 00:12:24, sky wrote: > Can ...
6 years ago (2014-12-13 00:35:28 UTC) #16
sky
LGTM https://codereview.chromium.org/800933002/diff/70001/ash/virtual_keyboard_controller.h File ash/virtual_keyboard_controller.h (right): https://codereview.chromium.org/800933002/diff/70001/ash/virtual_keyboard_controller.h#newcode41 ash/virtual_keyboard_controller.h:41: bool IsSmartVirtualKeyboardEnabled(); This function doesn't need any state ...
6 years ago (2014-12-15 15:50:53 UTC) #17
rsadam
https://codereview.chromium.org/800933002/diff/70001/ash/virtual_keyboard_controller.h File ash/virtual_keyboard_controller.h (right): https://codereview.chromium.org/800933002/diff/70001/ash/virtual_keyboard_controller.h#newcode41 ash/virtual_keyboard_controller.h:41: bool IsSmartVirtualKeyboardEnabled(); On 2014/12/15 15:50:53, sky wrote: > This ...
6 years ago (2014-12-15 16:29:40 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/800933002/90001
6 years ago (2014-12-15 16:29:58 UTC) #20
commit-bot: I haz the power
Committed patchset #6 (id:90001)
6 years ago (2014-12-15 18:11:46 UTC) #21
commit-bot: I haz the power
6 years ago (2014-12-15 18:12:40 UTC) #22
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/47e23d2c8d8611f87b6de3b8f5f3b3c4a3307577
Cr-Commit-Position: refs/heads/master@{#308373}

Powered by Google App Engine
This is Rietveld 408576698