Turns on smart deployment of the virtual keyboard by default, and changes the flag to allow easy di…

ash/virtual_keyboard_controller.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_VIRTUAL_KEYBOARD_CONTROLLER_H_
 #define ASH_VIRTUAL_KEYBOARD_CONTROLLER_H_
 
 #include "ash/ash_export.h"
 #include "ash/shell_observer.h"
 #include "ash/system/tray/system_tray_notifier.h"
@@ skipping 19 matching lines @@
   virtual void OnKeyboardDeviceConfigurationChanged() override;
 
   // Toggles whether the presense of an external keyboard should be ignored
   // when determining whether or not to show the on-screen keyboard.
   void ToggleIgnoreExternalKeyboard();
 
  private:
   // Updates the list of active input devices.
   void UpdateDevices();
 
+  // Checks whether smart deployment is enabled.
+  bool IsSmartVirtualKeyboardEnabled();

[sky, 2014/12/15 15:50:53]

This function doesn't need any state from VirtualKeyboardController. Move it
into an anonymous function in the .cc.

[rsadam, 2014/12/15 16:29:40]

Done.

+
   // Updates the keyboard state.
   void UpdateKeyboardEnabled();
 
   // Creates the keyboard if |enabled|, else destroys it.
   void SetKeyboardEnabled(bool enabled);
 
   // True if an external keyboard is connected.
   bool has_external_keyboard_;
   // True if an internal keyboard is connected.
   bool has_internal_keyboard_;
   // True if a touchscreen is connected.
   bool has_touchscreen_;
   // True if the presense of an external keyboard should be ignored.
   bool ignore_external_keyboard_;
 
   DISALLOW_COPY_AND_ASSIGN(VirtualKeyboardController);
 };
 
 }  // namespace ash
 
 #endif  // ASH_VIRTUAL_KEYBOARD_CONTROLLER_H_