Resolve lint warnings related to DefaultLocale and SimpleDateFormat

Resolve lint warnings related to DefaultLocale and SimpleDateFormat

The following lint warnings needs to be fixed as they are legitimate:

(1) org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizer.java
    Implicitly using the default locale is a common source of bugs:
    Use `toLowerCase(Locale)` instead: DefaultLocale [warning]

(2) org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java
    To get local formatting use `getDateInstance()`, `getDateTimeInstance()`,
    or `getTimeInstance()`, or use `new SimpleDateFormat(String template, Locale locale)`
    with for example `Locale.US` for ASCII dates.: SimpleDateFormat [warning]

Fixing these warning by specifying the locale in respective classes.
If a locale cannot be determined, Locale.getDefault() in case of (2).

BUG=None.

Committed: https://crrev.com/0b6c944932295452eca35de6b036797efbbe5f23
Cr-Commit-Position: refs/heads/master@{#310242}

[wajahat, 2015-01-05 08:43:22]

wajahat.s@samsung.com changed reviewers:
+ newt@chromium.org, nyquist@chromium.org

[wajahat, 2015-01-05 08:43:23]

Pl. review, Thanks!

[newt (away), 2015-01-05 18:23:37]

https://codereview.chromium.org/800903004/diff/1/chrome/android/java/src/org/...
File
chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizer.java
(right):

https://codereview.chromium.org/800903004/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizer.java:293:
Locale.ENGLISH);
Actually, this should be "Locale.US" (to be consistent with the Android lint
tool recommendation and the Chromium codebase)

[nyquist, 2015-01-05 21:41:40]

nyquist@chromium.org changed reviewers:
+ ianwen@chromium.org

[nyquist, 2015-01-05 21:41:40]

ianwen: Does the change to AutofillCreditCardEditor look OK to you?

[newt (away), 2015-01-05 21:55:42]

On 2015/01/05 21:41:40, nyquist wrote:
> ianwen: Does the change to AutofillCreditCardEditor look OK to you?

FWIW, AutofillCreditCardEditor looks good to me

[wajahat, 2015-01-06 08:41:44]

Thanks for the review,
Comments incorporated in OmniboxUrlEmphasizer class, PTAL!

https://codereview.chromium.org/800903004/diff/1/chrome/android/java/src/org/...
File
chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizer.java
(right):

https://codereview.chromium.org/800903004/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizer.java:293:
Locale.ENGLISH);
On 2015/01/05 18:23:37, newt wrote:
> Actually, this should be "Locale.US" (to be consistent with the Android lint
> tool recommendation and the Chromium codebase)

Done.

[newt (away), 2015-01-06 15:42:35]

lgtm

[nyquist, 2015-01-06 16:40:31]

lgtm

[wajahat, 2015-01-07 05:43:53]

The CQ bit was checked by wajahat.s@samsung.com

[commit-bot: I haz the power, 2015-01-07 05:44:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/800903004/20001

[commit-bot: I haz the power, 2015-01-07 06:48:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-01-07 06:49:36]

Patchset 2 (id:??) landed as
https://crrev.com/0b6c944932295452eca35de6b036797efbbe5f23
Cr-Commit-Position: refs/heads/master@{#310242}