Resolve lint warnings related to DefaultLocale and SimpleDateFormat

chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizer.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.omnibox;
 
 import android.content.res.Resources;
 import android.text.Spannable;
 import android.text.style.ForegroundColorSpan;
 import android.text.style.StrikethroughSpan;
 
 import org.chromium.base.VisibleForTesting;
 import org.chromium.chrome.R;
 import org.chromium.chrome.browser.profiles.Profile;
 import org.chromium.chrome.browser.ui.toolbar.ToolbarModelSecurityLevel;
 
+import java.util.Locale;
+
 /**
  * A helper class that emphasizes the various components of a URL. Useful in the
  * Omnibox and Origin Info dialog where different parts of the URL should appear
  * in different colours depending on the scheme, host and connection.
  */
 public class OmniboxUrlEmphasizer {
 
     /**
      * Describes the components of a URL that should be emphasized.
      */
@@ skipping 253 matching lines @@
      * @param profile The profile visiting this URL (used for parsing the URL).
      * @return The index of the last character containing origin information.
      */
     public static int getOriginEndIndex(String url, Profile profile) {
         EmphasizeComponentsResponse emphasizeResponse =
                 parseForEmphasizeComponents(profile, url.toString());
         if (!emphasizeResponse.hasScheme()) return url.length();
 
         int startSchemeIndex = emphasizeResponse.schemeStart;
         int endSchemeIndex = emphasizeResponse.schemeStart + emphasizeResponse.schemeLength;
-        String scheme = url.subSequence(startSchemeIndex, endSchemeIndex).toString().toLowerCase();
+        String scheme = url.subSequence(startSchemeIndex, endSchemeIndex).toString().toLowerCase(
+                Locale.ENGLISH);

[newt (away), 2015/01/05 18:23:37]

Actually, this should be "Locale.US" (to be consistent with the Android lint
tool recommendation and the Chromium codebase)

[wajahat, 2015/01/06 08:41:43]

Done.

 
         if (scheme.equals("http") || scheme.equals("https")) {
             return emphasizeResponse.hostStart + emphasizeResponse.hostLength;
         } else if (scheme.equals("data")) {
             return 0;
         } else {
             return url.length();
         }
     }
 
     private static native int[] nativeParseForEmphasizeComponents(Profile profile, String text);
 }