Issue 800713006: [turbofan] Turn DCHECK for fixed slot index into a CHECK.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 800713006: [turbofan] Turn DCHECK for fixed slot index into a CHECK. (Closed)

Created:
6 years ago by Benedikt Meurer

Modified:
6 years ago

Reviewers:
Igor Sheludko

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

[turbofan] Turn DCHECK for fixed slot index into a CHECK. This is a temporary workaround to ensure that we crash in release mode instead of running into undefined behavior. BUG=chromium:444681 LOG=y R=ishell@chromium.org Committed: https://crrev.com/0a03b5ef188e6d9dfbbed05652eb63d31db2a7da Cr-Commit-Position: refs/heads/master@{#25933}

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/compiler/instruction.h	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/0a03b5ef188e6d9dfbbed05652eb63d31db2a7da Cr-Commit-Position: refs/heads/master@{#25933}

6 years ago (2014-12-23 11:01:05 UTC) #4

Benedikt Meurer

6 years ago (2014-12-23 11:01:05 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0a03b5ef188e6d9dfbbed05652eb63d31db2a7da (presubmit successful).