Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: src/compiler/instruction.h

Issue 800713006: [turbofan] Turn DCHECK for fixed slot index into a CHECK. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/instruction.h
diff --git a/src/compiler/instruction.h b/src/compiler/instruction.h
index 41cda82fc1b204921532ca2defd17baa40bd1a0b..4ce89ddd97ce193118d9736cfd5058c305e034ef 100644
--- a/src/compiler/instruction.h
+++ b/src/compiler/instruction.h
@@ -129,7 +129,8 @@ class UnallocatedOperand : public InstructionOperand {
value_ |= VirtualRegisterField::encode(kInvalidVirtualRegister);
value_ |= BasicPolicyField::encode(policy);
value_ |= index << FixedSlotIndexField::kShift;
- DCHECK(this->fixed_slot_index() == index);
+ // TODO(dcarney): 2^10 is not enough for the fixed slot index.
+ CHECK(this->fixed_slot_index() == index);
}
UnallocatedOperand(ExtendedPolicy policy, int index)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698