chrome/browser/resources/options/browser_options.js - Issue 800523002: [Hotword] Sync Audio History pref every 24 hours, when opening chrome://settings and . . .

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/browser_options.js

Issue 800523002: [Hotword] Sync Audio History pref every 24 hours, when opening chrome://settings and . . . (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Doing It Right Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/hotword_private/hotword_private_apitest.cc ('k') | chrome/browser/search/hotword_audio_history_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/browser_options.js

diff --git a/chrome/browser/resources/options/browser_options.js b/chrome/browser/resources/options/browser_options.js

index 1b36e91a2f81fb48d24f2b7212e2cdbb4754ded8..b0a0e80c209407207d7fd1cb586f60a2e1ceaf7a 100644

--- a/chrome/browser/resources/options/browser_options.js

+++ b/chrome/browser/resources/options/browser_options.js

@@ -1231,10 +1231,11 @@ cr.define('options', function() {

/**

* Activates the Audio History section of the Settings page.

* @param {boolean} alwaysOn Whether always-on hotwording is available.

+ * @param {boolean} visible Whether the audio history section is visible.

Dan Beam 2014/12/12 22:08:31 nit: I'd arguably make this param first

rpetterson 2014/12/12 22:22:28 Done.

* @private

- showAudioHistorySection_: function(alwaysOn) {

- $('audio-history').hidden = false;

+ setAudioHistorySectionVisible_: function(alwaysOn, visible) {

+ $('audio-history').hidden = !visible;

$('audio-history-always-on-description').hidden = !alwaysOn;

@@ -2136,7 +2137,7 @@ cr.define('options', function() {

'setVirtualKeyboardCheckboxState',

'setupPageZoomSelector',

'setupProxySettingsButton',

- 'showAudioHistorySection',

+ 'setAudioHistorySectionVisible',

'showBluetoothSettings',

'showCreateProfileError',

'showCreateProfileSuccess',