Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: chrome/browser/extensions/api/hotword_private/hotword_private_apitest.cc

Issue 800523002: [Hotword] Sync Audio History pref every 24 hours, when opening chrome://settings and . . . (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Doing It Right Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/hotword_private/hotword_private_apitest.cc
diff --git a/chrome/browser/extensions/api/hotword_private/hotword_private_apitest.cc b/chrome/browser/extensions/api/hotword_private/hotword_private_apitest.cc
index 39ae48143fe06d759100f993ec3954296b255bd8..b001ade3387e376173af30b973e4cc4a3f307c00 100644
--- a/chrome/browser/extensions/api/hotword_private/hotword_private_apitest.cc
+++ b/chrome/browser/extensions/api/hotword_private/hotword_private_apitest.cc
@@ -65,7 +65,8 @@ class MockAudioHistoryHandler : public HotwordAudioHistoryHandler {
public:
MockAudioHistoryHandler(content::BrowserContext* context,
history::WebHistoryService* web_history)
- : HotwordAudioHistoryHandler(context),
+ : HotwordAudioHistoryHandler(context,
+ base::MessageLoop::current()->task_runner()),
web_history_(web_history) {}
~MockAudioHistoryHandler() override {}
@@ -442,9 +443,13 @@ IN_PROC_BROWSER_TEST_F(HotwordPrivateApiTest, AudioHistoryNoWebHistory) {
new MockAudioHistoryHandler(profile(), nullptr);
service()->SetAudioHistoryHandler(handler);
- ExtensionTestMessageListener setListenerT("set AH: false failure", false);
- ExtensionTestMessageListener setListenerF("set AH: false failure", false);
- ExtensionTestMessageListener getListener("get AH: false failure", false);
+ // Set an initial value for the audio logging pref.
+ PrefService* prefs = profile()->GetPrefs();
+ prefs->SetBoolean(prefs::kHotwordAudioLoggingEnabled, true);
+
+ ExtensionTestMessageListener setListenerT("set AH: true failure", false);
+ ExtensionTestMessageListener setListenerF("set AH: true failure", false);
+ ExtensionTestMessageListener getListener("get AH: true failure", false);
ASSERT_TRUE(RunComponentExtensionTest("audioHistory")) << message_;

Powered by Google App Engine
This is Rietveld 408576698