Update TrayPopupHeaderButton Visual Feedback

Update TrayPopupHeaderButton Visual Feedback

Add a new background to TrayPopupHeaderButton which is used for both mouse and touch feedback. Mouse hover, and tap down, events will trigger the background. Completing a click or tap, or exiting the button, will remove the feedback.

The size of TrayPopupHeadButton has been updated according to the new spec in issue 402515.

TEST=TrayDetailsViewTest.TrayPopupHeaderButtonTouchFeedback, TrayDetailsViewTest.TrayPopupHeaderButtonTouchFeedbackCancellation, TrayDetailsViewTest.TrayPopupHeaderButtonMouseHoverFeedback
BUG=402515
Committed: https://crrev.com/7cb27c033a1c3410f26bed928e051cad50f5b750
Cr-Commit-Position: refs/heads/master@{#308000}

[jonross, 2014-12-11 16:44:46]

jonross@chromium.org changed reviewers:
+ skuhne@chromium.org

[jonross, 2014-12-11 16:44:47]

Hi Stefan,

Could you review this change? I am updating the visual feedback for the buttons
that appear at the bottom of system tray bubbles. Such as the Lock/Power
buttons.

Thanks,
Jon

[Mr4D (OOO till 08-26), 2014-12-11 19:50:10]

lgtm after addressing the nits

https://codereview.chromium.org/800513002/diff/1/ash/system/tray/tray_details...
File ash/system/tray/tray_details_view_unittest.cc (right):

https://codereview.chromium.org/800513002/diff/1/ash/system/tray/tray_details...
ash/system/tray/tray_details_view_unittest.cc:236: TEST_F(TrayDetailsViewTest,
TrayPopupHeaderButtonTouchFeedback) {
Nice! unit tests!

https://codereview.chromium.org/800513002/diff/1/ash/system/tray/tray_details...
ash/system/tray/tray_details_view_unittest.cc:277: TEST_F(TrayDetailsViewTest,
TrayPopupHeaderButtonMouseHoverFeedback) {
Is there any danger that touch + mouse in combination might cause problems?

https://codereview.chromium.org/800513002/diff/1/ash/system/tray/tray_popup_h...
File ash/system/tray/tray_popup_header_button.cc (right):

https://codereview.chromium.org/800513002/diff/1/ash/system/tray/tray_popup_h...
ash/system/tray/tray_popup_header_button.cc:10: #include "ui/gfx/canvas.h"
I think you can get rid of this now.

https://codereview.chromium.org/800513002/diff/1/ash/system/tray/tray_popup_h...
ash/system/tray/tray_popup_header_button.cc:58: if (state() == STATE_HOVERED ||
state() == STATE_PRESSED)
Since more lines, please use {}

[jonross, 2014-12-11 21:41:42]

https://codereview.chromium.org/800513002/diff/1/ash/system/tray/tray_details...
File ash/system/tray/tray_details_view_unittest.cc (right):

https://codereview.chromium.org/800513002/diff/1/ash/system/tray/tray_details...
ash/system/tray/tray_details_view_unittest.cc:277: TEST_F(TrayDetailsViewTest,
TrayPopupHeaderButtonMouseHoverFeedback) {
On 2014/12/11 19:50:10, Mr4D wrote:
> Is there any danger that touch + mouse in combination might cause problems?

Nope. Both mouse and touch end up triggering ButtonState changes, using the same
states. So both inputs end up triggering the same location for background
changes.

https://codereview.chromium.org/800513002/diff/1/ash/system/tray/tray_popup_h...
File ash/system/tray/tray_popup_header_button.cc (right):

https://codereview.chromium.org/800513002/diff/1/ash/system/tray/tray_popup_h...
ash/system/tray/tray_popup_header_button.cc:10: #include "ui/gfx/canvas.h"
On 2014/12/11 19:50:10, Mr4D wrote:
> I think you can get rid of this now.

Done.

https://codereview.chromium.org/800513002/diff/1/ash/system/tray/tray_popup_h...
ash/system/tray/tray_popup_header_button.cc:58: if (state() == STATE_HOVERED ||
state() == STATE_PRESSED)
On 2014/12/11 19:50:10, Mr4D wrote:
> Since more lines, please use {}

Foiled by git cl format!

Done

[jonross, 2014-12-11 21:41:46]

The CQ bit was checked by jonross@chromium.org

[commit-bot: I haz the power, 2014-12-11 23:08:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/800513002/20001

[commit-bot: I haz the power, 2014-12-12 00:01:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-12-12 00:01:51]

Patchset 2 (id:??) landed as
https://crrev.com/7cb27c033a1c3410f26bed928e051cad50f5b750
Cr-Commit-Position: refs/heads/master@{#308000}