Update TrayPopupHeaderButton Visual Feedback

ash/system/tray/tray_popup_header_button.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/system/tray/tray_popup_header_button.h"
 
 #include "ash/ash_constants.h"
 #include "ash/system/tray/tray_constants.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/canvas.h"

[Mr4D (OOO till 08-26), 2014/12/11 19:50:10]

I think you can get rid of this now.

[jonross, 2014/12/11 21:41:41]

Done.

+#include "ui/views/background.h"
 #include "ui/views/painter.h"
 
 namespace ash {
 
 // static
 const char TrayPopupHeaderButton::kViewClassName[] =
     "tray/TrayPopupHeaderButton";
 
 TrayPopupHeaderButton::TrayPopupHeaderButton(views::ButtonListener* listener,
                                              int enabled_resource_id,
@@ skipping 25 matching lines @@
 TrayPopupHeaderButton::~TrayPopupHeaderButton() {}
 
 const char* TrayPopupHeaderButton::GetClassName() const {
   return kViewClassName;
 }
 
 gfx::Size TrayPopupHeaderButton::GetPreferredSize() const {
   return gfx::Size(ash::kTrayPopupItemHeight, ash::kTrayPopupItemHeight);
 }
 
-void TrayPopupHeaderButton::OnPaintBorder(gfx::Canvas* canvas) {
-  // Just the left border.
-  const int kBorderHeight = 25;
-  int padding = (height() - kBorderHeight) / 2;
-  canvas->FillRect(gfx::Rect(0, padding, 1, height() - padding * 2),
-      ash::kBorderDarkColor);
-}
-
 void TrayPopupHeaderButton::StateChanged() {
+  if (state() == STATE_HOVERED || state() == STATE_PRESSED)

[Mr4D (OOO till 08-26), 2014/12/11 19:50:10]

Since more lines, please use {}

[jonross, 2014/12/11 21:41:41]

Foiled by git cl format!

Done

+    set_background(views::Background::CreateSolidBackground(
+        kTrayPopupHoverBackgroundColor));
+  else
+    set_background(nullptr);
   SchedulePaint();
 }
 
 }  // namespace ash