Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 800503002: PushRegistration.unregister(), cleanups and more tests. (Closed)

Created:
6 years ago by mlamouri (slow - plz ping)
Modified:
6 years ago
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@push_unregister
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

PushRegistration.unregister(), cleanups and more tests. This is part of a multi-sided CL: Part 1: https://codereview.chromium.org/793913002/ Part 2: https://codereview.chromium.org/793403002/ Part 3: <this> BUG=440958 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187482

Patch Set 1 #

Total comments: 2

Patch Set 2 : moar tests #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -15 lines) Patch
M LayoutTests/http/tests/push_messaging/unregister.html View 1 3 chunks +15 lines, -7 lines 0 comments Download
M public/platform/WebPushProvider.h View 1 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
mlamouri (slow - plz ping)
6 years ago (2014-12-11 16:30:44 UTC) #3
mlamouri (slow - plz ping)
6 years ago (2014-12-11 16:30:45 UTC) #4
mlamouri (slow - plz ping)
+jochen@ given that Mike is currently sick.
6 years ago (2014-12-12 10:48:23 UTC) #6
Michael van Ouwerkerk
lgtm with nits https://codereview.chromium.org/800503002/diff/1/LayoutTests/http/tests/push_messaging/unregister.html File LayoutTests/http/tests/push_messaging/unregister.html (right): https://codereview.chromium.org/800503002/diff/1/LayoutTests/http/tests/push_messaging/unregister.html#newcode32 LayoutTests/http/tests/push_messaging/unregister.html:32: .then(function(unregistration_result) { Please rename this to ...
6 years ago (2014-12-12 13:59:49 UTC) #8
jochen (gone - plz use gerrit)
lgtm
6 years ago (2014-12-12 14:26:45 UTC) #9
Mike West
LGTM, sorry I was out most of last week. :/
6 years ago (2014-12-15 08:36:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/800503002/40001
6 years ago (2014-12-18 16:32:20 UTC) #12
commit-bot: I haz the power
6 years ago (2014-12-18 18:30:32 UTC) #13
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187482

Powered by Google App Engine
This is Rietveld 408576698