Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: public/platform/WebPushProvider.h

Issue 800503002: PushRegistration.unregister(), cleanups and more tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@push_unregister
Patch Set: rebase Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/http/tests/push_messaging/unregister.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/platform/WebPushProvider.h
diff --git a/public/platform/WebPushProvider.h b/public/platform/WebPushProvider.h
index 892910852f2746d513ffe921f66229fdfe6c13db..af5d353ca5dd451d46d832c0eb8b02074d23df42 100644
--- a/public/platform/WebPushProvider.h
+++ b/public/platform/WebPushProvider.h
@@ -37,14 +37,7 @@ public:
// Takes ownership if the WebPushUnregisterCallbacks.
// Does not take ownership of the WebServiceWorkerRegistration.
- virtual void unregister(WebServiceWorkerRegistration*, WebPushUnregisterCallbacks* callback)
- {
- // FIXME: this should call BLINK_ASSERT_NOT_REACHED() when Chromium will
- // have an implementation.
- bool result = true;
- callback->onSuccess(&result);
- delete callback;
- }
+ virtual void unregister(WebServiceWorkerRegistration*, WebPushUnregisterCallbacks* callback) { BLINK_ASSERT_NOT_REACHED(); }
};
} // namespace blink
« no previous file with comments | « LayoutTests/http/tests/push_messaging/unregister.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698