Don't include hidden windows in IsAppWindowRegisteredInAnyProfile.

Don't include hidden windows in IsAppWindowRegisteredInAnyProfile.

All the places that use this function are checking whether there are any app
windows from the point of view of the user.

BUG=442280
Committed: https://crrev.com/261f7f3a466211792b0613c0d736e069fa1a7cc2
Cr-Commit-Position: refs/heads/master@{#310196}

[jackhou1, 2015-01-06 00:43:57]

jackhou@chromium.org changed reviewers:
+ tapted@chromium.org

[jackhou1, 2015-01-06 00:43:58]

tapted, WDYT?

Most uses of this function are on Mac, and all the callers would want to exclude
hidden windows.

The only other use is VerifyASHSwitchForApps in apps_metro_handler_win.cc. It's
meant to check whether any apps are open before restarting Chrome in Ash mode. I
think it should probably exclude hidden windows, but if not, we could add either
a new parameter |include_hidden| or a new function
IsVisibleAppWindowInAnyProfile.

[tapted, 2015-01-06 00:51:29]

cool - I like it. But we should change the name of the function (and update the
header comment)

https://codereview.chromium.org/800473006/diff/20001/chrome/browser/apps/app_...
File chrome/browser/apps/app_window_registry_util.cc (right):

https://codereview.chromium.org/800473006/diff/20001/chrome/browser/apps/app_...
chrome/browser/apps/app_window_registry_util.cc:44: bool
AppWindowRegistryUtil::IsAppWindowRegisteredInAnyProfile(
IsAppWindowRegisteredInAnyProfile -> IsAppWindowVisibleInAnyProfile

https://codereview.chromium.org/800473006/diff/20001/chrome/browser/apps/app_...
chrome/browser/apps/app_window_registry_util.cc:60: for
(AppWindowList::const_iterator j = app_windows.begin();
oooh range-based-for!

https://codereview.chromium.org/800473006/diff/20001/chrome/browser/apps/app_...
chrome/browser/apps/app_window_registry_util.cc:63: (window_type_mask == 0 ||
(*j)->window_type() & window_type_mask)) {
nit: brackets around the bitwise '&'

[jackhou1, 2015-01-06 02:13:14]

https://codereview.chromium.org/800473006/diff/20001/chrome/browser/apps/app_...
File chrome/browser/apps/app_window_registry_util.cc (right):

https://codereview.chromium.org/800473006/diff/20001/chrome/browser/apps/app_...
chrome/browser/apps/app_window_registry_util.cc:44: bool
AppWindowRegistryUtil::IsAppWindowRegisteredInAnyProfile(
On 2015/01/06 00:51:28, tapted wrote:
> IsAppWindowRegisteredInAnyProfile -> IsAppWindowVisibleInAnyProfile

Done.

https://codereview.chromium.org/800473006/diff/20001/chrome/browser/apps/app_...
chrome/browser/apps/app_window_registry_util.cc:60: for
(AppWindowList::const_iterator j = app_windows.begin();
On 2015/01/06 00:51:28, tapted wrote:
> oooh range-based-for!

Done.

https://codereview.chromium.org/800473006/diff/20001/chrome/browser/apps/app_...
chrome/browser/apps/app_window_registry_util.cc:63: (window_type_mask == 0 ||
(*j)->window_type() & window_type_mask)) {
On 2015/01/06 00:51:28, tapted wrote:
> nit: brackets around the bitwise '&'

Done.

[tapted, 2015-01-06 02:50:48]

lgtm

https://codereview.chromium.org/800473006/diff/40001/chrome/browser/apps/app_...
File chrome/browser/apps/app_window_registry_util.cc (right):

https://codereview.chromium.org/800473006/diff/40001/chrome/browser/apps/app_...
chrome/browser/apps/app_window_registry_util.cc:63: (window->window_type() &
window_type_mask))) {
optional-nit: up to you if you want the curly brace - it's not needed when just
the condition is multi-line but the body is a single line

[jackhou1, 2015-01-06 06:05:58]

https://codereview.chromium.org/800473006/diff/40001/chrome/browser/apps/app_...
File chrome/browser/apps/app_window_registry_util.cc (right):

https://codereview.chromium.org/800473006/diff/40001/chrome/browser/apps/app_...
chrome/browser/apps/app_window_registry_util.cc:63: (window->window_type() &
window_type_mask))) {
On 2015/01/06 02:50:47, tapted wrote:
> optional-nit: up to you if you want the curly brace - it's not needed when
just
> the condition is multi-line but the body is a single line

Done.

[jackhou1, 2015-01-06 06:06:41]

jackhou@chromium.org changed reviewers:
+ rsesek@chromium.org

[jackhou1, 2015-01-06 06:06:41]

rsesek, could you review for OWNERS of:

chrome/browser/app_controller_mac.mm

[Robert Sesek, 2015-01-06 16:20:38]

lgtm

[jackhou1, 2015-01-07 00:46:52]

The CQ bit was checked by jackhou@chromium.org

[commit-bot: I haz the power, 2015-01-07 00:47:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/800473006/60001

[commit-bot: I haz the power, 2015-01-07 00:59:31]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-01-07 01:00:46]

Patchset 4 (id:??) landed as
https://crrev.com/261f7f3a466211792b0613c0d736e069fa1a7cc2
Cr-Commit-Position: refs/heads/master@{#310196}