Don't include hidden windows in IsAppWindowRegisteredInAnyProfile.

chrome/browser/apps/app_window_registry_util.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/apps/app_window_registry_util.h"
 
 #include <vector>
 
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 23 matching lines @@
 
     AppWindow* app_window = registry->GetAppWindowForNativeWindow(window);
     if (app_window)
       return app_window;
   }
 
   return NULL;
 }
 
 // static
 bool AppWindowRegistryUtil::IsAppWindowRegisteredInAnyProfile(

[tapted, 2015/01/06 00:51:28]

IsAppWindowRegisteredInAnyProfile -> IsAppWindowVisibleInAnyProfile

[jackhou1, 2015/01/06 02:13:14]

Done.

     int window_type_mask) {
   std::vector<Profile*> profiles =
       g_browser_process->profile_manager()->GetLoadedProfiles();
   for (std::vector<Profile*>::const_iterator i = profiles.begin();
        i != profiles.end();
        ++i) {
     AppWindowRegistry* registry =
         Factory::GetForBrowserContext(*i, false /* create */);
     if (!registry)
       continue;
 
     const AppWindowList& app_windows = registry->app_windows();
     if (app_windows.empty())
       continue;
 
-    if (window_type_mask == 0)
-      return true;
-
     for (AppWindowList::const_iterator j = app_windows.begin();

[tapted, 2015/01/06 00:51:28]

oooh range-based-for!

[jackhou1, 2015/01/06 02:13:14]

Done.

          j != app_windows.end(); ++j) {
-      if ((*j)->window_type() & window_type_mask)
+      if (!(*j)->is_hidden() &&
+          (window_type_mask == 0 || (*j)->window_type() & window_type_mask)) {

[tapted, 2015/01/06 00:51:28]

nit: brackets around the bitwise '&'

[jackhou1, 2015/01/06 02:13:14]

Done.

         return true;
+      }
     }
   }
 
   return false;
 }
 
 // static
 void AppWindowRegistryUtil::CloseAllAppWindows() {
   std::vector<Profile*> profiles =
       g_browser_process->profile_manager()->GetLoadedProfiles();
   for (std::vector<Profile*>::const_iterator i = profiles.begin();
        i != profiles.end();
        ++i) {
     AppWindowRegistry* registry =
         Factory::GetForBrowserContext(*i, false /* create */);
     if (!registry)
       continue;
 
     while (!registry->app_windows().empty())
       registry->app_windows().front()->GetBaseWindow()->Close();
   }
 }