Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Issue 800143003: Sync android-chrome revision along with chromium on android-chrome platform. (Closed)

Created:
5 years, 11 months ago by prasadv
Modified:
5 years, 11 months ago
Reviewers:
qyearsley
CC:
RobertoCN
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sync android-chrome revision along with chromium on android-chrome platform. android-chrome revision is overwritten with TOT revision when we sync only chromium revision. This causes inconsistency between android-chrome and chromium revisions that we want to bisect. Therefore we pass android-chrome revision along with chromium revision to make sure we are bisect chromium on proper android-chrome revision. BUG=447348 NOTRY=true Committed: https://crrev.com/a2fe607ce642aac9ce063d84ee79b92ff256e436 Cr-Commit-Position: refs/heads/master@{#310681}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -6 lines) Patch
M tools/auto_bisect/bisect_perf_regression.py View 2 chunks +24 lines, -1 line 0 comments Download
M tools/auto_bisect/bisect_perf_regression_test.py View 1 1 chunk +26 lines, -0 lines 0 comments Download
M tools/auto_bisect/bisect_utils.py View 2 chunks +6 lines, -4 lines 0 comments Download
M tools/auto_bisect/source_control.py View 1 1 chunk +17 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
prasadv
5 years, 11 months ago (2015-01-08 22:51:35 UTC) #2
qyearsley
LGTM, looks like my comments from before were addressed. I'm still wondering whether RunGClientAndSync (and ...
5 years, 11 months ago (2015-01-09 00:46:46 UTC) #3
prasadv
5 years, 11 months ago (2015-01-09 02:34:02 UTC) #4
qyearsley
On 2015/01/09 02:34:02, prasadv wrote: Test lgtm :-)
5 years, 11 months ago (2015-01-09 02:34:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/800143003/20001
5 years, 11 months ago (2015-01-09 02:36:14 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-09 02:37:59 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 02:39:20 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a2fe607ce642aac9ce063d84ee79b92ff256e436
Cr-Commit-Position: refs/heads/master@{#310681}

Powered by Google App Engine
This is Rietveld 408576698