Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: tools/auto_bisect/bisect_perf_regression.py

Issue 800143003: Sync android-chrome revision along with chromium on android-chrome platform. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/auto_bisect/bisect_perf_regression_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/auto_bisect/bisect_perf_regression.py
diff --git a/tools/auto_bisect/bisect_perf_regression.py b/tools/auto_bisect/bisect_perf_regression.py
index 2de8f2ca2d731d550812be5430bd30790c3717e4..df60f26b9dc07904989397ffe6d6bfcc0d90be75 100755
--- a/tools/auto_bisect/bisect_perf_regression.py
+++ b/tools/auto_bisect/bisect_perf_regression.py
@@ -1409,7 +1409,7 @@ class BisectPerformanceMetrics(object):
Returns:
True if successful.
"""
- if self.opts.target_platform == 'android':
+ if 'android' in self.opts.target_platform:
if not builder.SetupAndroidBuildEnvironment(self.opts,
path_to_src=self.src_cwd):
return False
@@ -1540,9 +1540,32 @@ class BisectPerformanceMetrics(object):
if sync_client == 'gclient' and revision:
revision = '%s@%s' % (bisect_utils.DEPOT_DEPS_NAME[depot]['src'],
revision)
+ if depot == 'chromium' and self.opts.target_platform == 'android-chrome':
+ return self._SyncRevisionsForAndroidChrome(revision)
return source_control.SyncToRevision(revision, sync_client)
+ def _SyncRevisionsForAndroidChrome(self, revision):
+ """Syncs android-chrome and chromium repos to particular revision.
+
+ This is a special case for android-chrome as the gclient sync for chromium
+ overwrites the android-chrome revision to TOT. Therefore both the repos
+ are synced to known revisions.
+
+ Args:
+ revision: Git hash of the Chromium to sync.
+
+ Returns:
+ True if successful, False otherwise.
+ """
+ revisions_list = [revision]
+ current_android_rev = source_control.GetCurrentRevision(
+ self.depot_registry.GetDepotDir('android-chrome'))
+ revisions_list.append(
+ '%s@%s' % (bisect_utils.DEPOT_DEPS_NAME['android-chrome']['src'],
+ current_android_rev))
+ return not bisect_utils.RunGClientAndSync(revisions_list)
+
def _CheckIfRunPassed(self, current_value, known_good_value, known_bad_value):
"""Given known good and bad values, decide if the current_value passed
or failed.
« no previous file with comments | « no previous file | tools/auto_bisect/bisect_perf_regression_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698