chrome/browser/ui/app_list/app_list_controller_browsertest.cc - Issue 800023004: app_list: OnExtensionLoaded calls UpdateResults asynchronously rather than directly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/app_list_controller_browsertest.cc

Issue 800023004: app_list: OnExtensionLoaded calls UpdateResults asynchronously rather than directly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix test Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/app_list/app_list_controller_browsertest.cc

diff --git a/chrome/browser/ui/app_list/app_list_controller_browsertest.cc b/chrome/browser/ui/app_list/app_list_controller_browsertest.cc

index dc5e9df7f699ad6c07e8f593e96c9b910d8e8a0a..e47d90be33f280c905fd10260579081d50a8c16d 100644

--- a/chrome/browser/ui/app_list/app_list_controller_browsertest.cc

+++ b/chrome/browser/ui/app_list/app_list_controller_browsertest.cc

@@ -205,6 +205,9 @@ IN_PROC_BROWSER_TEST_F(AppListControllerSearchResultsBrowserTest,

// Now uninstall and ensure this browser test observes it.

UninstallExtension(extension->id());

+ // Allow async AppSearchProvider::UpdateResults to run.

+ base::RunLoop().RunUntilIdle();

EXPECT_FALSE(observed_result_);

StopWatchingResults();

service->DismissAppList();

« no previous file with comments | « no previous file | chrome/browser/ui/app_list/search/app_search_provider.h » ('j') | chrome/browser/ui/app_list/search/app_search_provider.cc » ('J')