chrome/browser/ui/app_list/app_list_controller_browsertest.cc - Issue 800023004: app_list: OnExtensionLoaded calls UpdateResults asynchronously rather than directly.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/app_list/app_list_controller_browsertest.cc

Issue 800023004: app_list: OnExtensionLoaded calls UpdateResults asynchronously rather than directly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix test Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/browser/ui/app_list/search/app_search_provider.h » ('j') | chrome/browser/ui/app_list/search/app_search_provider.cc » ('J')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/command_line.h"	5 #include "base/command_line.h"

6 #include "base/path_service.h"	6 #include "base/path_service.h"

7 #include "base/run_loop.h"	7 #include "base/run_loop.h"

8 #include "base/strings/utf_string_conversions.h"	8 #include "base/strings/utf_string_conversions.h"

9 #include "chrome/browser/extensions/extension_browsertest.h"	9 #include "chrome/browser/extensions/extension_browsertest.h"

10 #include "chrome/browser/profiles/profile.h"	10 #include "chrome/browser/profiles/profile.h"

(...skipping 187 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
198 EXPECT_FALSE(observed_result_);	198 EXPECT_FALSE(observed_result_);

199 model->search_box()->SetText(base::ASCIIToUTF16("minimal"));	199 model->search_box()->SetText(base::ASCIIToUTF16("minimal"));

200 EXPECT_TRUE(observed_result_);	200 EXPECT_TRUE(observed_result_);

201	201

202 // Ensure the UI is updated. This is via PostTask in views.	202 // Ensure the UI is updated. This is via PostTask in views.

203 base::RunLoop().RunUntilIdle();	203 base::RunLoop().RunUntilIdle();

204	204

205 // Now uninstall and ensure this browser test observes it.	205 // Now uninstall and ensure this browser test observes it.

206 UninstallExtension(extension->id());	206 UninstallExtension(extension->id());

207	207

	208 // Allow async AppSearchProvider::UpdateResults to run.

	209 base::RunLoop().RunUntilIdle();

	210

208 EXPECT_FALSE(observed_result_);	211 EXPECT_FALSE(observed_result_);

209 StopWatchingResults();	212 StopWatchingResults();

210 service->DismissAppList();	213 service->DismissAppList();

211 }	214 }

OLD	NEW