Enable 3rd party support for Security Keys.

Enable 3rd party support for Security Keys.

Updates cryptotoken to 0.9.10:
 - Implement eTLD+1 checking of appIds
 - Smaller bugfixes

BUG=426358
R=juanlang,xiyuan

Committed: https://crrev.com/d60fcd7caafaffff7046da693fe2c3206ab5cf20
Cr-Commit-Position: refs/heads/master@{#308259}

[Arnar Birgisson, 2014-12-13 04:09:18]

Hi Xiyuan.

Please review, pending Juan's regular approval as well. This uses our fancy new
API, I'll cc you on testing instructions as well.

cheers,
Arnar

[juanlang, 2014-12-13 04:15:03]

lgtm

[xiyuan, 2014-12-13 04:36:30]

https://codereview.chromium.org/799923007/diff/1/chrome/browser/resources/cry...
File chrome/browser/resources/cryptotoken/manifest.json (right):

https://codereview.chromium.org/799923007/diff/1/chrome/browser/resources/cry...
chrome/browser/resources/cryptotoken/manifest.json:11: "cryptotokenPrivate",
Isn't this listed on line 8 already?

https://codereview.chromium.org/799923007/diff/1/chrome/browser/resources/cry...
chrome/browser/resources/cryptotoken/manifest.json:12:
"externally_connectable.all_urls",
This looks wrong. Line 27 looks the one needed.

[juanlang, 2014-12-13 04:42:39]

https://codereview.chromium.org/799923007/diff/1/chrome/browser/resources/cry...
File chrome/browser/resources/cryptotoken/manifest.json (right):

https://codereview.chromium.org/799923007/diff/1/chrome/browser/resources/cry...
chrome/browser/resources/cryptotoken/manifest.json:12:
"externally_connectable.all_urls",
On 2014/12/13 04:36:30, xiyuan wrote:
> This looks wrong. Line 27 looks the one needed.

They're both needed: this permission is required to set the matches string, see
https://codereview.chromium.org/599163003

[xiyuan, 2014-12-13 04:46:09]

https://codereview.chromium.org/799923007/diff/1/chrome/browser/resources/cry...
File chrome/browser/resources/cryptotoken/manifest.json (right):

https://codereview.chromium.org/799923007/diff/1/chrome/browser/resources/cry...
chrome/browser/resources/cryptotoken/manifest.json:12:
"externally_connectable.all_urls",
On 2014/12/13 04:42:39, juanlang wrote:
> On 2014/12/13 04:36:30, xiyuan wrote:
> > This looks wrong. Line 27 looks the one needed.
> 
> They're both needed: this permission is required to set the matches string,
see
> https://codereview.chromium.org/599163003

Aha. You are right. Ignore my comment then. :p

[Arnar Birgisson, 2014-12-13 04:46:53]

https://codereview.chromium.org/799923007/diff/1/chrome/browser/resources/cry...
File chrome/browser/resources/cryptotoken/manifest.json (right):

https://codereview.chromium.org/799923007/diff/1/chrome/browser/resources/cry...
chrome/browser/resources/cryptotoken/manifest.json:11: "cryptotokenPrivate",
On 2014/12/13 04:36:30, xiyuan wrote:
> Isn't this listed on line 8 already?

Done.  Indeed, bad merge.

https://codereview.chromium.org/799923007/diff/1/chrome/browser/resources/cry...
chrome/browser/resources/cryptotoken/manifest.json:12:
"externally_connectable.all_urls",
On 2014/12/13 04:42:39, juanlang wrote:
> On 2014/12/13 04:36:30, xiyuan wrote:
> > This looks wrong. Line 27 looks the one needed.
> 
> They're both needed: this permission is required to set the matches string,
see
> https://codereview.chromium.org/599163003

Acknowledged. We tested with only line 27 and it indeed didn't suffice.

[xiyuan, 2014-12-13 04:47:38]

LGTM with the extra cryptotokenPrivate permission removed.

[Arnar Birgisson, 2014-12-13 04:48:36]

The CQ bit was checked by arnarb@chromium.org

[commit-bot: I haz the power, 2014-12-13 04:49:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/799923007/20001

[commit-bot: I haz the power, 2014-12-13 08:14:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-12-13 08:15:44]

Patchset 2 (id:??) landed as
https://crrev.com/d60fcd7caafaffff7046da693fe2c3206ab5cf20
Cr-Commit-Position: refs/heads/master@{#308259}