Source/core/frame/LocalFrame.h - Issue 799923006: Make canNavigate() OOPI-friendly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/LocalFrame.h

Issue 799923006: Make canNavigate() OOPI-friendly (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Address dcheng's comments Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/frame/LocalFrame.h

diff --git a/Source/core/frame/LocalFrame.h b/Source/core/frame/LocalFrame.h

index 6c9afe62a2b8cf05b293cf46b7e25cd1c393e4c6..7d4c012422515555136f12479b395a74b05fc870 100644

--- a/Source/core/frame/LocalFrame.h

+++ b/Source/core/frame/LocalFrame.h

@@ -87,6 +87,7 @@ namespace blink {

virtual void disconnectOwnerElement() override;

virtual SecurityContext* securityContext() const override;

bool checkLoadComplete() override;

+ virtual void printNavigationErrorMessage(const Frame&, const char* reason) override;

dcheng 2015/01/08 00:44:59 No virtual.

Nate Chapin 2015/01/08 17:10:52 Someday I'll remember. Done.

void addDestructionObserver(FrameDestructionObserver*);

void removeDestructionObserver(FrameDestructionObserver*);