Chromium Code Reviews Chromium Code Reviews
Issue 799923006:
Make canNavigate() OOPI-friendly (Closed)
Base URL: svn://svn.chromium.org/blink/trunk| OLD | NEW |
|---|---|
| 1 /* | 1 /* |
| 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> | 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> |
| 3 * 1999-2001 Lars Knoll <knoll@kde.org> | 3 * 1999-2001 Lars Knoll <knoll@kde.org> |
| 4 * 1999-2001 Antti Koivisto <koivisto@kde.org> | 4 * 1999-2001 Antti Koivisto <koivisto@kde.org> |
| 5 * 2000-2001 Simon Hausmann <hausmann@kde.org> | 5 * 2000-2001 Simon Hausmann <hausmann@kde.org> |
| 6 * 2000-2001 Dirk Mueller <mueller@kde.org> | 6 * 2000-2001 Dirk Mueller <mueller@kde.org> |
| 7 * 2000 Stefan Schimanski <1Stein@gmx.de> | 7 * 2000 Stefan Schimanski <1Stein@gmx.de> |
| 8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. | 8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. |
| 9 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) | 9 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) |
| 10 * Copyright (C) 2008 Eric Seidel <eric@webkit.org> | 10 * Copyright (C) 2008 Eric Seidel <eric@webkit.org> |
| (...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 80 virtual ~LocalFrame(); | 80 virtual ~LocalFrame(); |
| 81 virtual void trace(Visitor*) override; | 81 virtual void trace(Visitor*) override; |
| 82 virtual bool isLocalFrame() const override { return true; } | 82 virtual bool isLocalFrame() const override { return true; } |
| 83 virtual DOMWindow* domWindow() const override; | 83 virtual DOMWindow* domWindow() const override; |
| 84 virtual void navigate(Document& originDocument, const KURL&, bool lockBa ckForwardList) override; | 84 virtual void navigate(Document& originDocument, const KURL&, bool lockBa ckForwardList) override; |
| 85 virtual void reload(ReloadPolicy, ClientRedirectPolicy) override; | 85 virtual void reload(ReloadPolicy, ClientRedirectPolicy) override; |
| 86 virtual void detach() override; | 86 virtual void detach() override; |
| 87 virtual void disconnectOwnerElement() override; | 87 virtual void disconnectOwnerElement() override; |
| 88 virtual SecurityContext* securityContext() const override; | 88 virtual SecurityContext* securityContext() const override; |
| 89 bool checkLoadComplete() override; | 89 bool checkLoadComplete() override; |
| 90 virtual void printNavigationErrorMessage(const Frame&, const char* reaso n) override; | |
|
dcheng
2015/01/08 00:44:59
No virtual.
Nate Chapin
2015/01/08 17:10:52
Someday I'll remember. Done.
| |
| 90 | 91 |
| 91 void addDestructionObserver(FrameDestructionObserver*); | 92 void addDestructionObserver(FrameDestructionObserver*); |
| 92 void removeDestructionObserver(FrameDestructionObserver*); | 93 void removeDestructionObserver(FrameDestructionObserver*); |
| 93 | 94 |
| 94 void willDetachFrameHost(); | 95 void willDetachFrameHost(); |
| 95 | 96 |
| 96 LocalDOMWindow* localDOMWindow() const; | 97 LocalDOMWindow* localDOMWindow() const; |
| 97 void setDOMWindow(PassRefPtrWillBeRawPtr<LocalDOMWindow>); | 98 void setDOMWindow(PassRefPtrWillBeRawPtr<LocalDOMWindow>); |
| 98 FrameView* view() const; | 99 FrameView* view() const; |
| 99 Document* document() const; | 100 Document* document() const; |
| (...skipping 189 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 289 DEFINE_TYPE_CASTS(LocalFrame, Frame, localFrame, localFrame->isLocalFrame(), localFrame.isLocalFrame()); | 290 DEFINE_TYPE_CASTS(LocalFrame, Frame, localFrame, localFrame->isLocalFrame(), localFrame.isLocalFrame()); |
| 290 | 291 |
| 291 } // namespace blink | 292 } // namespace blink |
| 292 | 293 |
| 293 // During refactoring, there are some places where we need to do type conversion s that | 294 // During refactoring, there are some places where we need to do type conversion s that |
| 294 // will not be needed once all instances of LocalFrame and RemoteFrame are sorte d out. | 295 // will not be needed once all instances of LocalFrame and RemoteFrame are sorte d out. |
| 295 // At that time this #define will be removed and all the uses of it will need to be corrected. | 296 // At that time this #define will be removed and all the uses of it will need to be corrected. |
| 296 #define toLocalFrameTemporary toLocalFrame | 297 #define toLocalFrameTemporary toLocalFrame |
| 297 | 298 |
| 298 #endif // LocalFrame_h | 299 #endif // LocalFrame_h |
| OLD | NEW |
