Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 799723003: StoreMode enum values renamed. (Closed)

Created:
6 years ago by Igor Sheludko
Modified:
6 years ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

StoreMode enum values renamed. FORCE_FIELD -> FORCE_IN_OBJECT, ALLOW_AS_CONSTANT -> ALLOW_IN_DESCRIPTOR.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -24 lines) Patch
M src/objects.h View 1 1 chunk +1 line, -4 lines 0 comments Download
M src/objects.cc View 1 12 chunks +20 lines, -20 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Igor Sheludko
PTAL
6 years ago (2014-12-12 13:23:22 UTC) #2
Jakob Kummerow
LGTM with a nit. https://codereview.chromium.org/799723003/diff/1/src/objects.h File src/objects.h (right): https://codereview.chromium.org/799723003/diff/1/src/objects.h#newcode245 src/objects.h:245: enum StoreMode { ALLOW_AS_IN_DESCRIPTOR, FORCE_IN_OBJECT ...
6 years ago (2014-12-12 15:02:19 UTC) #3
Igor Sheludko
https://codereview.chromium.org/799723003/diff/1/src/objects.h File src/objects.h (right): https://codereview.chromium.org/799723003/diff/1/src/objects.h#newcode245 src/objects.h:245: enum StoreMode { ALLOW_AS_IN_DESCRIPTOR, FORCE_IN_OBJECT }; On 2014/12/12 15:02:19, ...
6 years ago (2014-12-12 15:08:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/799723003/20001
6 years ago (2014-12-12 15:08:42 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-12 15:36:03 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001)

Powered by Google App Engine
This is Rietveld 408576698