app_list: Exclude Objective-C from cpplint pass.

app_list: Exclude Objective-C from cpplint pass.

BUG=349250
R=tapted@chromium.org

Committed: https://crrev.com/2a83d9f5375c33d124d4b4d7b4ed933b44e5957e
Cr-Commit-Position: refs/heads/master@{#308031}

[tfarina, 2014-12-11 23:59:39]

PTAL

[tapted, 2014-12-12 00:12:42]

https://codereview.chromium.org/799713002/diff/1/ui/app_list/PRESUBMIT.py
File ui/app_list/PRESUBMIT.py (right):

https://codereview.chromium.org/799713002/diff/1/ui/app_list/PRESUBMIT.py#new...
ui/app_list/PRESUBMIT.py:18: r'.*_mac\.(cc|h)$',
a foo_mac.cc file won't have any Objective C in it - they should still get
checked. (I know chrome/PRESUBMIT.py has this, but it could be improved).

For app list I think we just need to ignore the cocoa folder:

EXCLUDE = (
  r'.*/cocoa/.*'
)

Everything in there is objective C and there's nothing that isn't.

Approach otherwise looks nice.

[tfarina, 2014-12-12 00:21:28]

Thanks for the review Trent! :)

https://codereview.chromium.org/799713002/diff/1/ui/app_list/PRESUBMIT.py
File ui/app_list/PRESUBMIT.py (right):

https://codereview.chromium.org/799713002/diff/1/ui/app_list/PRESUBMIT.py#new...
ui/app_list/PRESUBMIT.py:18: r'.*_mac\.(cc|h)$',
On 2014/12/12 00:12:42, tapted wrote:
> a foo_mac.cc file won't have any Objective C in it - they should still get
> checked. (I know chrome/PRESUBMIT.py has this, but it could be improved).
> 
> For app list I think we just need to ignore the cocoa folder:
> 
> EXCLUDE = (
>   r'.*/cocoa/.*'
> )
> 
> Everything in there is objective C and there's nothing that isn't.
> 
> Approach otherwise looks nice.

Done.

https://codereview.chromium.org/799713002/diff/20001/ui/app_list/PRESUBMIT.py
File ui/app_list/PRESUBMIT.py (right):

https://codereview.chromium.org/799713002/diff/20001/ui/app_list/PRESUBMIT.py...
ui/app_list/PRESUBMIT.py:12: r'.*\.cc$', r'.*\.h$'
Do you think we could simplify this to the following?

r'.*\.(cc|h)$'

[tapted, 2014-12-12 00:35:46]

lgtm

https://codereview.chromium.org/799713002/diff/20001/ui/app_list/PRESUBMIT.py
File ui/app_list/PRESUBMIT.py (right):

https://codereview.chromium.org/799713002/diff/20001/ui/app_list/PRESUBMIT.py...
ui/app_list/PRESUBMIT.py:12: r'.*\.cc$', r'.*\.h$'
On 2014/12/12 00:21:28, tfarina wrote:
> Do you think we could simplify this to the following?
> 
> r'.*\.(cc|h)$'
> 

yeah - that should work. I've fine if you roll it in here.

[tfarina, 2014-12-12 01:03:13]

https://codereview.chromium.org/799713002/diff/20001/ui/app_list/PRESUBMIT.py
File ui/app_list/PRESUBMIT.py (right):

https://codereview.chromium.org/799713002/diff/20001/ui/app_list/PRESUBMIT.py...
ui/app_list/PRESUBMIT.py:12: r'.*\.cc$', r'.*\.h$'
On 2014/12/12 00:35:46, tapted wrote:
> On 2014/12/12 00:21:28, tfarina wrote:
> > Do you think we could simplify this to the following?
> > 
> > r'.*\.(cc|h)$'
> > 
> 
> yeah - that should work. I've fine if you roll it in here.

Done.

[tapted, 2014-12-12 01:27:10]

slgtm - thanks!

[tfarina, 2014-12-12 01:32:46]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-12-12 01:34:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/799713002/40001

[commit-bot: I haz the power, 2014-12-12 02:32:58]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-12-12 02:33:36]

Patchset 3 (id:??) landed as
https://crrev.com/2a83d9f5375c33d124d4b4d7b4ed933b44e5957e
Cr-Commit-Position: refs/heads/master@{#308031}