OLD | NEW |
---|---|
1 # Copyright 2014 The Chromium Authors. All rights reserved. | 1 # Copyright 2014 The Chromium Authors. All rights reserved. |
2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
4 | 4 |
5 """Presubmit script for app_list. | 5 """Presubmit script for app_list. |
6 | 6 |
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
8 for more details about the presubmit API built into depot_tools. | 8 for more details about the presubmit API built into depot_tools. |
9 """ | 9 """ |
10 | |
10 INCLUDE_CPP_FILES_ONLY = ( | 11 INCLUDE_CPP_FILES_ONLY = ( |
11 r'.*\.cc$', r'.*\.h$' | 12 r'.*\.cc$', r'.*\.h$' |
tfarina
2014/12/12 00:21:28
Do you think we could simplify this to the followi
tapted
2014/12/12 00:35:46
yeah - that should work. I've fine if you roll it
tfarina
2014/12/12 01:03:12
Done.
| |
12 ) | 13 ) |
13 | 14 |
15 EXCLUDE = ( | |
16 # Objective C confuses everything. | |
17 r'.*/cocoa/.*', | |
18 ) | |
19 | |
14 def CheckChangeLintsClean(input_api, output_api): | 20 def CheckChangeLintsClean(input_api, output_api): |
15 """Makes sure that the ui/app_list/ code is cpplint clean.""" | 21 """Makes sure that the ui/app_list/ code is cpplint clean.""" |
22 black_list = input_api.DEFAULT_BLACK_LIST + EXCLUDE | |
16 sources = lambda x: input_api.FilterSourceFile( | 23 sources = lambda x: input_api.FilterSourceFile( |
17 x, white_list = INCLUDE_CPP_FILES_ONLY, black_list = None) | 24 x, white_list = INCLUDE_CPP_FILES_ONLY, black_list = black_list) |
18 return input_api.canned_checks.CheckChangeLintsClean( | 25 return input_api.canned_checks.CheckChangeLintsClean( |
19 input_api, output_api, sources) | 26 input_api, output_api, sources) |
20 | 27 |
21 def CheckChangeOnUpload(input_api, output_api): | 28 def CheckChangeOnUpload(input_api, output_api): |
22 results = [] | 29 results = [] |
23 results += CheckChangeLintsClean(input_api, output_api) | 30 results += CheckChangeLintsClean(input_api, output_api) |
24 results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api) | 31 results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api) |
25 return results | 32 return results |
OLD | NEW |