 Chromium Code Reviews
 Chromium Code Reviews Issue 799633007:
  Make Windows accessibility event firing aware of guest / child frames.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@webview_fixes
    
  
    Issue 799633007:
  Make Windows accessibility event firing aware of guest / child frames.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@webview_fixes| Index: content/browser/frame_host/frame_accessibility.h | 
| diff --git a/content/browser/frame_host/frame_accessibility.h b/content/browser/frame_host/frame_accessibility.h | 
| index 253ba19b0544fa04058e9324de1f2269af445568..43d4bd107af73fd7b5733086673e8f1ca0386392 100644 | 
| --- a/content/browser/frame_host/frame_accessibility.h | 
| +++ b/content/browser/frame_host/frame_accessibility.h | 
| @@ -48,6 +48,13 @@ class CONTENT_EXPORT FrameAccessibility { | 
| RenderFrameHostImpl* GetChild(RenderFrameHostImpl* parent_frame_host, | 
| int accessibility_node_id); | 
| + // Given a parent RenderFrameHostImpl and an accessibility node id, look up | 
| + // all child frames or guest frames that was previously associated with this | 
| 
nasko
2015/01/15 21:44:38
nit: s/was/were/
 
dmazzoni
2015/01/15 23:09:22
Done.
 | 
| + // frame, and populate |child_frame_hosts| with all of them that resolve | 
| + // to a valid RenderFrameHostImpl. | 
| + void GetAllChildFrames(RenderFrameHostImpl* parent_frame_host, | 
| + std::vector<RenderFrameHostImpl*>* child_frame_hosts); | 
| + | 
| // Given a RenderFrameHostImpl, check the mapping table to see if it's | 
| // the child of a node in some other frame. If so, return true and | 
| // set the parent frame and accessibility node id in the parent frame, | 
| @@ -60,6 +67,10 @@ class CONTENT_EXPORT FrameAccessibility { | 
| FrameAccessibility(); | 
| virtual ~FrameAccessibility(); | 
| + RenderFrameHostImpl* GetRFHIFromFrameTreeNodeId( | 
| + RenderFrameHostImpl* parent_frame_host, | 
| + int64 child_frame_tree_node_id); | 
| + | 
| struct ChildFrameMapping { | 
| 
nasko
2015/01/15 21:44:38
I know this isn't part of this CL, but this struct
 
dmazzoni
2015/01/15 23:09:22
It's a bit odd but I think it's right - I added so
 
nasko
2015/01/16 00:20:33
Thanks! It is a lot better. I'm curious why this i
 | 
| ChildFrameMapping(); |