Make Windows accessibility event firing aware of guest / child frames.

content/browser/frame_host/frame_accessibility.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_FRAME_HOST_FRAME_ACCESSIBILITY_H_
 #define CONTENT_BROWSER_FRAME_HOST_FRAME_ACCESSIBILITY_H_
 
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 30 matching lines @@
   void OnRenderFrameHostDestroyed(RenderFrameHostImpl* render_frame_host);
 
   // Given a parent RenderFrameHostImpl and an accessibility node id, look up
   // a child frame or guest frame that was previously associated with this
   // frame and node id. If a mapping exists, return the resulting frame if
   // it's valid. If it doesn't resolve to a valid RenderFrameHostImpl,
   // returns NULL.
   RenderFrameHostImpl* GetChild(RenderFrameHostImpl* parent_frame_host,
                                 int accessibility_node_id);
 
+  // Given a parent RenderFrameHostImpl and an accessibility node id, look up
+  // all child frames or guest frames that was previously associated with this

[nasko, 2015/01/15 21:44:38]

nit: s/was/were/

[dmazzoni, 2015/01/15 23:09:22]

Done.

+  // frame, and populate |child_frame_hosts| with all of them that resolve
+  // to a valid RenderFrameHostImpl.
+  void GetAllChildFrames(RenderFrameHostImpl* parent_frame_host,
+                         std::vector<RenderFrameHostImpl*>* child_frame_hosts);
+
   // Given a RenderFrameHostImpl, check the mapping table to see if it's
   // the child of a node in some other frame. If so, return true and
   // set the parent frame and accessibility node id in the parent frame,
   // otherwise return false.
   bool GetParent(RenderFrameHostImpl* child_frame_host,
                  RenderFrameHostImpl** out_parent_frame_host,
                  int* out_accessibility_node_id);
 
  private:
   FrameAccessibility();
   virtual ~FrameAccessibility();
 
+  RenderFrameHostImpl* GetRFHIFromFrameTreeNodeId(
+      RenderFrameHostImpl* parent_frame_host,
+      int64 child_frame_tree_node_id);
+
   struct ChildFrameMapping {

[nasko, 2015/01/15 21:44:38]

I know this isn't part of this CL, but this struct is missing a comment, so I
don't know what it is actually used for. Pairing RFH and FrameTreeNode ID
doesn't seem quite right.

[dmazzoni, 2015/01/15 23:09:22]

It's a bit odd but I think it's right - I added some comments, see if it makes
more sense now.

[nasko, 2015/01/16 00:20:33]

Thanks! It is a lot better. I'm curious why this is needed for iframes, but I
can see it for browser plugin. It will be neat if we can remove that once
<webview> uses iframes instead of browser plugin.

     ChildFrameMapping();
 
     RenderFrameHostImpl* parent_frame_host;
     int accessibility_node_id;
     int64 child_frame_tree_node_id;
     int browser_plugin_instance_id;
   };
 
   std::vector<ChildFrameMapping> mappings_;
 
   friend struct DefaultSingletonTraits<FrameAccessibility>;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_FRAME_HOST_FRAME_ACCESSIBILITY_H_