Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: tools/telemetry/telemetry/user_story/user_story_runner_unittest.py

Issue 799543006: Add Errors to user_story_runner to avoid benchmarks staying green when there are archive errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/user_story/user_story_runner.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/user_story/user_story_runner_unittest.py
diff --git a/tools/telemetry/telemetry/user_story/user_story_runner_unittest.py b/tools/telemetry/telemetry/user_story/user_story_runner_unittest.py
index 51d4b4d54124b1bd8af8c9d131ba9f6b9bc6238e..95fa88dd0f88a79ea07176df523329f9ab31a957 100644
--- a/tools/telemetry/telemetry/user_story/user_story_runner_unittest.py
+++ b/tools/telemetry/telemetry/user_story/user_story_runner_unittest.py
@@ -438,16 +438,20 @@ class UserStoryRunnerTest(unittest.TestCase):
uss.AddUserStory(page_module.Page(
'http://www.testurl.com', uss, uss.base_dir))
# Page set missing archive_data_file.
- self.assertFalse(user_story_runner._UpdateAndCheckArchives(
- uss.archive_data_file, uss.wpr_archive_info, uss.user_stories))
+ self.assertRaises(
+ user_story_runner.ArchiveError,
+ user_story_runner._UpdateAndCheckArchives,
+ uss.archive_data_file, uss.wpr_archive_info, uss.user_stories)
uss = user_story_set.UserStorySet(
archive_data_file='missing_archive_data_file.json')
uss.AddUserStory(page_module.Page(
'http://www.testurl.com', uss, uss.base_dir))
# Page set missing json file specified in archive_data_file.
- self.assertFalse(user_story_runner._UpdateAndCheckArchives(
- uss.archive_data_file, uss.wpr_archive_info, uss.user_stories))
+ self.assertRaises(
+ user_story_runner.ArchiveError,
+ user_story_runner._UpdateAndCheckArchives,
+ uss.archive_data_file, uss.wpr_archive_info, uss.user_stories)
uss = user_story_set.UserStorySet(
archive_data_file='../../unittest_data/test.json',
@@ -460,8 +464,10 @@ class UserStoryRunnerTest(unittest.TestCase):
uss.AddUserStory(page_module.Page(
'http://www.google.com', uss, uss.base_dir))
# Page set with an archive_data_file which exists but is missing a page.
- self.assertFalse(user_story_runner._UpdateAndCheckArchives(
- uss.archive_data_file, uss.wpr_archive_info, uss.user_stories))
+ self.assertRaises(
+ user_story_runner.ArchiveError,
+ user_story_runner._UpdateAndCheckArchives,
+ uss.archive_data_file, uss.wpr_archive_info, uss.user_stories)
uss = user_story_set.UserStorySet(
archive_data_file='../../unittest_data/test_missing_wpr_file.json',
@@ -472,8 +478,10 @@ class UserStoryRunnerTest(unittest.TestCase):
'http://www.google.com', uss, uss.base_dir))
# Page set with an archive_data_file which exists and contains all pages
# but fails to find a wpr file.
- self.assertFalse(user_story_runner._UpdateAndCheckArchives(
- uss.archive_data_file, uss.wpr_archive_info, uss.user_stories))
+ self.assertRaises(
+ user_story_runner.ArchiveError,
+ user_story_runner._UpdateAndCheckArchives,
+ uss.archive_data_file, uss.wpr_archive_info, uss.user_stories)
def _testMaxFailuresOptionIsRespectedAndOverridable(
« no previous file with comments | « tools/telemetry/telemetry/user_story/user_story_runner.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698