Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: tools/telemetry/telemetry/user_story/user_story_runner.py

Issue 799543006: Add Errors to user_story_runner to avoid benchmarks staying green when there are archive errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/user_story/user_story_runner_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/user_story/user_story_runner.py
diff --git a/tools/telemetry/telemetry/user_story/user_story_runner.py b/tools/telemetry/telemetry/user_story/user_story_runner.py
index 695c114f92ac8adb182d89326b1f901c92ac9138..dfc07a2a9cffa213bc967a8384cc52269474ae50 100644
--- a/tools/telemetry/telemetry/user_story/user_story_runner.py
+++ b/tools/telemetry/telemetry/user_story/user_story_runner.py
@@ -26,6 +26,10 @@ from telemetry.value import failure
from telemetry.value import skip
+class ArchiveError(Exception):
+ pass
+
+
def AddCommandLineArgs(parser):
user_story_filter.UserStoryFilter.AddCommandLineArgs(parser)
results_options.AddResultsOptions(parser)
@@ -324,13 +328,13 @@ def _UpdateAndCheckArchives(archive_data_file, wpr_archive_info,
'--use-live-sites.\nTo create an archive file add an '
'archive_data_file property to the user story set and then '
'run record_wpr.')
- return False
+ raise ArchiveError('No archive data file.')
if not wpr_archive_info:
logging.error('The archive info file is missing.\n'
'To fix this, either add svn-internal to your '
'.gclient using http://goto/read-src-internal, '
'or create a new archive using record_wpr.')
- return False
+ raise ArchiveError('No archive info file.')
wpr_archive_info.DownloadArchivesIfNeeded()
# Report any problems with individual user story.
@@ -366,7 +370,7 @@ def _UpdateAndCheckArchives(archive_data_file, wpr_archive_info,
', '.join(user_story.display_name
for user_story in user_stories_missing_archive_data))
if user_stories_missing_archive_path or user_stories_missing_archive_data:
- return False
+ raise ArchiveError('Archive file is missing user stories.')
# Only run valid user stories if no problems with the user story set or
# individual user stories.
return True
« no previous file with comments | « no previous file | tools/telemetry/telemetry/user_story/user_story_runner_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698